Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get feedback via Notifications - too much unuseful notifications #232

Closed
ufgum opened this issue Sep 10, 2023 · 1 comment · Fixed by #233
Closed

Get feedback via Notifications - too much unuseful notifications #232

ufgum opened this issue Sep 10, 2023 · 1 comment · Fixed by #233
Assignees
Labels
bug Something isn't working

Comments

@ufgum
Copy link

ufgum commented Sep 10, 2023

I set the "OCR mode" to "skip file completely":

image

When uploading a file which have OCR content already, I get a notification about "Workflow OCR error", but there is no error, no output is ok because OCR is not needed.
In the log I see this:

[workflow_ocr] Fehler: OCA\WorkflowOcr\Exception\OcrNotPossibleException: OCRmyPDF did not produce any output for file /uwe/files/ocrPDF/filename.pdf at <<closure>>

0. /home/www/nextcloud/apps/workflow_ocr/lib/Service/OcrService.php line 60
   OCA\WorkflowOcr\OcrProcessors\OcrMyPdfBasedProcessor->ocrFile()
1. /home/www/nextcloud/apps/workflow_ocr/lib/BackgroundJobs/ProcessFileJob.php line 146
   OCA\WorkflowOcr\Service\OcrService->ocrFile()
2. /home/www/nextcloud/apps/workflow_ocr/lib/BackgroundJobs/ProcessFileJob.php line 108
   OCA\WorkflowOcr\BackgroundJobs\ProcessFileJob->processFile()
3. /home/www/nextcloud/lib/public/BackgroundJob/Job.php line 81
   OCA\WorkflowOcr\BackgroundJobs\ProcessFileJob->run()
4. /home/www/nextcloud/lib/public/BackgroundJob/QueuedJob.php line 57
   OCP\BackgroundJob\Job->start()
5. /home/www/nextcloud/lib/public/BackgroundJob/QueuedJob.php line 47
   OCP\BackgroundJob\QueuedJob->start()
6. /home/www/nextcloud/cron.php line 152
   OCP\BackgroundJob\QueuedJob->execute()
@ufgum ufgum added the bug Something isn't working label Sep 10, 2023
@R0Wi
Copy link
Contributor

R0Wi commented Sep 14, 2023

Confirming that this is not the intended behaviour, thanks for reporting! Will try to get this fixed soon

R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
R0Wi added a commit that referenced this issue Oct 3, 2023
* Fixes #232
* Move logic to OcrService
@R0Wi R0Wi closed this as completed in #233 Oct 5, 2023
R0Wi added a commit that referenced this issue Oct 5, 2023
* Skip notifications when OCR mode is "skip file"

* Fixes #232
* Move logic to OcrService

* Cleanup code
R0Wi added a commit that referenced this issue Oct 5, 2023
* Skip notifications when OCR mode is "skip file"

* Fixes #232
* Move logic to OcrService

* Cleanup code
R0Wi added a commit that referenced this issue Oct 5, 2023
* Skip notifications when OCR mode is "skip file"

* Fixes #232
* Move logic to OcrService

* Cleanup code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants