Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Neovim 0.9.5 is broken #328

Open
jalvesaq opened this issue Feb 12, 2025 · 1 comment · May be fixed by #330
Open

Support for Neovim 0.9.5 is broken #328

jalvesaq opened this issue Feb 12, 2025 · 1 comment · May be fixed by #330

Comments

@jalvesaq
Copy link
Member

At least two commands don't work on Neovim 0.9.5: :RConfigShow and :RMapsDesc.

They don't work because the option split = "above" is invalid for vim.api.nvim_open_win() on Neovim 0.9.5.

The change using vim.api.nvim_open_win() was committed on December 27 (almost two months ago, #297, by @kkanden ) and nobody complained. Perhaps, there are not many people using R.nvim with Neovim 0.9.5. So, instead of fixing the code for this old version of Neovim, I suggest that we require Neovim 0.10.4 as the minimal version to run R.nvim...

@hongyuanjia has written the function utils.system() to ensure that R.nvim would work on Neovim 0.9.5 (see #36 and #41). Requiring Neovim 0.10.4, we will be able to use vim.system() and also vim.uv instead of vim.loop.

@PMassicotte
Copy link
Collaborator

Perhaps, there are not many people using R.nvim with Neovim 0.9.5. So, instead of fixing the code for this old version of Neovim, I suggest that we require Neovim 0.10.4 as the minimal version to run R.nvim...

I agree. I just installed nvim 0.9.5 for fun and nothing is working. A lot of errors concerning treesitter among others. I am ok to switch for a newer minimum version.

jalvesaq added a commit that referenced this issue Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants