Fix #191 and #188 #192
Merged
Fix #191 and #188 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahParry
reviewed
Jun 21, 2024
JosiahParry
reviewed
Jun 21, 2024
- Drop call to httr2::req_url_query - Incorporate new `arc_sr_as_crs()` - Use warning instead of error if query won't return full results
|
Thank you @elipousson! I pushed a single change that just adds comments to the function so that I can remember what is happening inside this function later. Once CI is green ill smash merge |
|
Windows is failing entirely illegibly. That can be a me problem at a later date. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devtools::document()devtools::check()passes locallyChanges
Fixes #191 by adding a helper function (
get_query_resps()) that handles layers that don't support pagination by using a standard query request.Also fixes the CRS bug #188 using a similar approach as the esri2sf package.
Issues that this closes
Fix #191 and #188
Follow up tasks
None identified.