Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standalone checks & assert n_max is a whole positive number #181

Closed
JosiahParry opened this issue Apr 12, 2024 · 0 comments
Closed

standalone checks & assert n_max is a whole positive number #181

JosiahParry opened this issue Apr 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JosiahParry
Copy link
Collaborator

Describe the bug
n_max in arc_select() and arc_read() can be set to a negative number. This causes an error to be propagated with a confusing message. Instead, there should be an assertion like check_whole_number() to do this. arcgisutils has imported the standalone checks with proper rlang namespacing. These should be incorporated into arcgislayers to perform these checks

@JosiahParry JosiahParry added the bug Something isn't working label Apr 12, 2024
JosiahParry added a commit that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant