Fix the wrong negation of the instanceof check #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!elem._parent instanceof type.UMLInterface
leads to negating the
elem._parent
and then doing theinstanceof
check, which will always result infalse
.Always returning
false
will lead tovar _modifiers = this.getModifiers(elem);
to not be called, which finally leads to_modifiers.includes("abstract")
to fail, because_modifiers
is not set