Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong negation of the instanceof check #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tim3trick
Copy link

!elem._parent instanceof type.UMLInterface
leads to negating the elem._parent and then doing the instanceof check, which will always result in false.

Always returning false will lead to var _modifiers = this.getModifiers(elem); to not be called, which finally leads to _modifiers.includes("abstract") to fail, because _modifiers is not set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant