Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migrating from V1 with module resolution "node' #7159

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Dec 13, 2024

What is it?

  • Bug

Description

Actually fixes #7130
Now migrating from V1 with moduleResolution: "node" in the tscofnig.json won't break typescript.

Checklist

@shairez shairez requested a review from a team as a code owner December 13, 2024 21:07
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 107dbc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7159
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7159
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7159
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7159

commit: 107dbc1

Copy link
Contributor

github-actions bot commented Dec 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 107dbc1

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wmertens wmertens merged commit 1def076 into build/v2 Dec 13, 2024
19 checks passed
@wmertens wmertens deleted the pr-fix-module-resolution branch December 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants