Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing projection content with null or undefined #7148

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Dec 11, 2024

Before we ignored children if they were equal to null or undefined. We should only ignore them if we don't have old projection slots and the children are null

closes #7147

@Varixo Varixo self-assigned this Dec 11, 2024
@Varixo Varixo requested a review from a team as a code owner December 11, 2024 16:00
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 9e4bf8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo linked an issue Dec 11, 2024 that may be closed by this pull request
Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7148
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7148
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7148
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7148

commit: 9e4bf8f

Copy link
Contributor

github-actions bot commented Dec 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 9e4bf8f

Copy link
Contributor

@shairez shairez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Varixo ! 🙏

@shairez shairez merged commit f75361c into build/v2 Dec 13, 2024
19 checks passed
@shairez shairez deleted the v2-replacing-projection-content-with-null branch December 13, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐞] V2 - Error with a <Slot /> that is conditionally rendered
2 participants