Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ref inside context #7132

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: ref inside context #7132

merged 1 commit into from
Dec 5, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Dec 5, 2024

No description provided.

@Varixo Varixo self-assigned this Dec 5, 2024
@Varixo Varixo requested a review from a team as a code owner December 5, 2024 14:58
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: eaa1604

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo force-pushed the v2-fix-ref-inside-context branch from 5cca728 to 626e2f4 Compare December 5, 2024 15:04
Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7132
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7132
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7132
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7132

commit: eaa1604

Copy link
Contributor

github-actions bot commented Dec 5, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview eaa1604

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

packages/qwik/src/core/shared/shared-serialization.ts Outdated Show resolved Hide resolved
packages/qwik/src/core/shared/shared-serialization.ts Outdated Show resolved Hide resolved
@Varixo Varixo force-pushed the v2-fix-ref-inside-context branch from 626e2f4 to bbec468 Compare December 5, 2024 15:39
@Varixo Varixo force-pushed the v2-fix-ref-inside-context branch from bbec468 to eaa1604 Compare December 5, 2024 15:44
@Varixo Varixo merged commit 9cdfc58 into build/v2 Dec 5, 2024
19 checks passed
@Varixo Varixo deleted the v2-fix-ref-inside-context branch December 5, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants