-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose unwrapStore as a low level API #6960
Conversation
🦋 Changeset detectedLatest commit: 39fd36d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this change, but in v2 we're calling this unwrapStore
which is a better name IMHO.
Can you change the export to unwrapStore
?
@GrandSchtroumpf can you update the change set and API docs so they all say unwrapStore? @shairez shall we put this in 1.9.2? |
@wmertens I updated the changeset. The doc still refers to unwrapProxy because this is the original name of the function. I can change |
Thanks @GrandSchtroumpf ! Add a few short comments about the changesets @wmertens please resolve the "request changes" when you have a chance |
nvm @GrandSchtroumpf But please read my review just as FYI for next time, thanks again for the PR! 🙏 |
What is it?
Description
unwrapProxy
was marked as a@public
API in JSDoc but wasn't exposed to the user.Exposing
unwrapProxy
enables developer to clone the content of auseStore()
usingstructureClone
or IndexedDBfix #6135
Checklist:
pnpm change
and documented my changes