Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cli build "hangs" #6943

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fixed cli build "hangs" #6943

merged 1 commit into from
Oct 7, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Oct 7, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Sometimes when running build (especially when using the static adapter), if there was a lint error it looked like the cli doesn't properly exit the process.

This fixes it so it always comes back to the terminal command line after errors.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@shairez shairez requested a review from a team as a code owner October 7, 2024 13:43
Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 1f424ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez self-assigned this Oct 7, 2024
Copy link

pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6943
npm i https://pkg.pr.new/@builder.io/qwik-city@6943
npm i https://pkg.pr.new/eslint-plugin-qwik@6943
npm i https://pkg.pr.new/create-qwik@6943

commit: 1f424ea

Copy link
Contributor

github-actions bot commented Oct 7, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1f424ea

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 3c2163f into main Oct 7, 2024
21 checks passed
@wmertens wmertens deleted the pr-fix-cli-stuck branch October 7, 2024 14:42
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants