Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-fetchpriority-with-modulepreload (DO NOT MERGE) #6829

Closed
wants to merge 290 commits into from
Closed

Test-fetchpriority-with-modulepreload (DO NOT MERGE) #6829

wants to merge 290 commits into from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 27, 2024 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

As discussed in https://discord.com/channels/842438759945601056/1276861655833383034/1277680025398804491

TLDR: I need this PR to test modulepreload with fetchpriority to low on qwik UI on a production setup to see if it fixes FCP and LCP issues with modulepreload.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

maiieul added 30 commits August 26, 2024 21:53
@maiieul
Revert "fix(docs): algolia search (QwikDev#6754)"
3993877 
This reverts commit d589fac.
@maiieul
Revert "refactor(dev): remove foundql from vite-dev-server"
b43f3b0 
This reverts commit 86d6378.
@maiieul
Revert "fix(optimizer): let the bundler handle entries"
60e0a7a 
This reverts commit 568132c.
@maiieul
Revert "fix(optimizer): correct side effect cleaner"
711fcc4 
This reverts commit 7b2ee07.
@maiieul
Revert "feat(vite-plugin): set assets path in build to /assets (QwikD…
2aaf7d7 
…ev#5745)"

This reverts commit 80abcff.
@maiieul
Revert "chore: update vite and vitest"
0123829 
This reverts commit 42880cf.
@maiieul
Revert "chore: fix plugin types"
6c24cbb 
This reverts commit 99296ea.
@maiieul
Revert "chore: dep update all minor packages"
09958a2 
This reverts commit f5fc443.
@maiieul
Revert "fix(eslint): pin dev versions, prevent issues with eslint"
17898ee 
This reverts commit 3c30ecd.
@maiieul
Revert "chore(rust): upgrade swc"
75a8c68 
This reverts commit 5a3d975.
@maiieul
Revert "fix(rust): workaround for qwik-napi test build fail"
c080a84 
This reverts commit 92ed808.
@maiieul
Revert "chore(rust): cargo clippy"
ab0d17c 
This reverts commit ae68a60.
@maiieul
Revert "chore: update rust and nix"
5e57f1c 
This reverts commit d73af62.
@maiieul
Revert "chore(rust): napi v2"
be333a5 
This reverts commit b3925d5.
@maiieul
Revert "chore(rust): cargo update + fixups"
fe76192 
This reverts commit 5250dc5.
@maiieul
Revert "chore(rust): lint"
7717391 
This reverts commit c7d8805.
@maiieul
Revert "fix(rust): replace unstable extract_if with retain"
3920ff2 
This reverts commit e8bd894.
@maiieul
Revert "feat(docs): add PkgManagers tabs (QwikDev#6636)"
c7d1ffc 
This reverts commit 99d6db4.
@maiieul
Revert "docs(auth): correct @auth/qwik documentation and add migratio…
f30a2be 
…n guide (QwikDev#6730)"

This reverts commit 14b27c8.
@maiieul
Revert "removed commitzen requirement from PR titles"
03c7aff 
This reverts commit ee8b9c5.
@maiieul
Revert "style: fix lint error"
e2a93f5 
This reverts commit 83d9185.
@maiieul
Revert "added docs for changesets"
ceef907 
This reverts commit 62dd297.
@maiieul
Revert "added pretty-quick and a pre-commit hook"
1e8255b 
This reverts commit 28dda10.
@maiieul
Revert "ci: fix validate-cli for eslint"
3a3cec4 
This reverts commit e2cc179.
@maiieul
Revert "Revert "ci: fix validate-cli for eslint""
106e3dd 
This reverts commit 3a3cec4.
@maiieul
Revert "Revert "added pretty-quick and a pre-commit hook""
f79beb3 
This reverts commit 1e8255b.
@maiieul
Revert "Revert "added docs for changesets""
578096f 
This reverts commit ceef907.
@maiieul
Revert "Revert "style: fix lint error""
d97a6bd 
This reverts commit e2a93f5.
@maiieul
Revert "Revert "removed commitzen requirement from PR titles""
8da7eda 
This reverts commit 03c7aff.
@maiieul
Revert "Revert "docs(auth): correct @auth/qwik documentation and add …
0af3c7a 
…migration guide (QwikDev#6730)""

This reverts commit f30a2be.
maiieul added 22 commits August 27, 2024 13:10
@maiieul
Revert "tests(qwik-city,e2e,nav): Add a test case for QwikDev#6660"
2abf830 
This reverts commit 4e1f31e.
@maiieul
Revert "fix(ci): print cloudflare summary in comments"
b5a5218 
This reverts commit e3c868c.
@maiieul
Revert "fix(changesets): version monorepo root"
2d81abb 
This reverts commit 4f40c29.
@maiieul
Revert "docs(getting-started): remove reference to HMR (QwikDev#6686)"
a66cab4 
This reverts commit c69495b.
@maiieul
Revert "chore: removed changeset test package"
52cae08 
This reverts commit 8125f6b.
@maiieul
Revert "ci: trying to fix publish"
f162d83 
This reverts commit dd70f6b.
@maiieul
Revert "chore: check changesets"
39b433c 
This reverts commit f6020c3.
@maiieul
Revert "chore: set qwik-labs to private"
fe086b7 
This reverts commit 880f5bc.
@maiieul
Revert "chore: added "insights" to changeset ignore"
d859bc4 
This reverts commit 88c8004.
@maiieul
Revert "ci: added qwik-labs to changesets ignore (QwikDev#6703)"
a8e9c89 
This reverts commit 79dd5a5.
@maiieul
Revert "chore: add missing publishConfig (QwikDev#6702)"
edae67a 
This reverts commit 977b935.
@maiieul
Revert "refactor: modified ci script and repl fix (QwikDev#6701)"
fbfa4fa 
This reverts commit 3805951.
@maiieul
Revert "Version Packages (QwikDev#6693)"
7e9cf7a 
This reverts commit b5b445b.
@maiieul
Revert "chore: add guarding to releases (QwikDev#6695)"
6b1a31e 
This reverts commit e5476a3.
@maiieul
Revert "ci: add missing dependency (QwikDev#6692)"
3badbec 
This reverts commit 30560ea.
@maiieul
Revert "feat: add changesets (QwikDev#6570)"
9ffa4c8 
This reverts commit 4e67d65.
@maiieul
Revert "chore: fix "STATUS-1" labels removal with workflow (QwikDev#6680
0a66432 
)"

This reverts commit 563ddc5.
@maiieul
Revert "fix(partytown-starter): using type import (QwikDev#6682)"
2d123a0 
This reverts commit 49d4c5d.
@maiieul
Revert "fix(dev): avoid warning in dev mode (QwikDev#6674)"
ec66860 
This reverts commit e4eb2c3.
@maiieul
Revert "fix: replace chunkFileNames logic (QwikDev#6675)"
8372cd4 
This reverts commit 9292a59.
@maiieul
Revert "chore: 1.7.1 (QwikDev#6672)"
e7e96d3 
This reverts commit 3c5e5a7.
@maiieul
chore: test fetchpriority option for link on 1.7.3 (DO NOT MERGE)
0510067
@maiieul maiieul requested review from mhevery, shairez and a team as code owners August 27, 2024 11:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: 0510067

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul closed this Aug 27, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 27, 2024

commit: 0510067

npm i https://pkg.pr.new/@builder.io/qwik@6829

npm i https://pkg.pr.new/@builder.io/qwik-city@6829

npm i https://pkg.pr.new/eslint-plugin-qwik@6829

npm i https://pkg.pr.new/create-qwik@6829

Open in Stackblitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhevery mhevery Awaiting requested review from mhevery mhevery is a code owner

@shairez shairez Awaiting requested review from shairez shairez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maiieul