Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move the env variable to guide/env-variable #6793

Merged
merged 1 commit into from
Aug 14, 2024
Merged

docs: move the env variable to guide/env-variable #6793

merged 1 commit into from
Aug 14, 2024

Conversation

Kampouse
Copy link
Contributor

What is it?

#6698

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@Kampouse Kampouse requested a review from a team as a code owner August 14, 2024 18:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 0ef7dea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 0ef7dea

gioboa
gioboa approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kampouse

@gioboa gioboa changed the title moved the env variable to guide/env-variable docs: move the env variable to guide/env-variable Aug 14, 2024
@gioboa gioboa added the COMP: docs Improvements or additions to documentation label Aug 14, 2024
@gioboa gioboa merged commit ddcc489 into QwikDev:main Aug 14, 2024
13 checks passed
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
91ce7c1 
…)"

This reverts commit ddcc489.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "Revert "docs: move the env variable to guide/env-variable (Qw…
c173840 
…ikDev#6793)""

This reverts commit 91ce7c1.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
260fcad 
…)"

This reverts commit ddcc489.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
f79bdb5 
…)"

This reverts commit ddcc489.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
5c24777 
…)"

This reverts commit ddcc489.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
17d2c7e 
…)"

This reverts commit ddcc489.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "Revert "docs: move the env variable to guide/env-variable (Qw…
980664a 
…ikDev#6793)""

This reverts commit 17d2c7e.
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
@maiieul
Revert "docs: move the env variable to guide/env-variable (QwikDev#6793…
d5e8ab7 
…)"

This reverts commit ddcc489.
wmertens pushed a commit that referenced this pull request Sep 24, 2024
@Kampouse @wmertens
docs: move the env variable to guide/env-variable (#6793)
7333b90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
COMP: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kampouse @gioboa