Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starter): update CLI version of storybook #6781

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

Kampouse
Copy link
Contributor

What is it?

Current cli version of npx qwik add storybook will run into
image

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

the pr update the starter to a healthy version
here a stackblitz with the said version
https://stackblitz.com/edit/github-sy5fgo-s1yms4?file=storyboard%2FREADME.md

Checklist:

  • [x ] My code follows the developer guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@Kampouse Kampouse requested a review from a team as a code owner August 10, 2024 18:39
Copy link

changeset-bot bot commented Aug 10, 2024

⚠️ No Changeset found

Latest commit: bc9b571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 10, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ❌ Failed (View Log) bc9b571

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kampouse 👏

@gioboa gioboa changed the title update CLI version of storybook fix(starter): update CLI version of storybook Aug 10, 2024
@gioboa gioboa merged commit 2175345 into QwikDev:main Aug 10, 2024
15 checks passed
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants