Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): ignore missing qrl segments #6761

Merged
merged 2 commits into from
Aug 5, 2024
Merged

fix(vite): ignore missing qrl segments #6761

merged 2 commits into from
Aug 5, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Aug 4, 2024

It's ok for a qrl export to be missing when it got tree shaken

@wmertens wmertens requested a review from a team as a code owner August 4, 2024 09:40
Copy link

changeset-bot bot commented Aug 4, 2024

⚠️ No Changeset found

Latest commit: 629d946

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens enabled auto-merge (squash) August 4, 2024 09:41
Copy link
Contributor

github-actions bot commented Aug 4, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ❌ Failed (View Log) 629d946

Copy link

pkg-pr-new bot commented Aug 4, 2024

commit: 629d946

npm i https://pkg.pr.new/@builder.io/qwik@6761
npm i https://pkg.pr.new/@builder.io/qwik-city@6761
npm i https://pkg.pr.new/eslint-plugin-qwik@6761
npm i https://pkg.pr.new/create-qwik@6761

Open in Stackblitz

@wmertens wmertens self-assigned this Aug 4, 2024
@wmertens wmertens requested review from a team as code owners August 5, 2024 12:52
@wmertens wmertens force-pushed the fix-treeshaken-qrl branch from 74ed5d9 to 629d946 Compare August 5, 2024 12:57
@wmertens
Copy link
Member Author

wmertens commented Aug 5, 2024

@shairez done, went all the way finally...

@wmertens wmertens merged commit 7afb605 into main Aug 5, 2024
21 checks passed
@wmertens wmertens deleted the fix-treeshaken-qrl branch August 5, 2024 13:30
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 26, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants