Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwik-city): redirect route loads when sane #6740

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(qwik-city): redirect route loads when sane #6740

merged 1 commit into from
Jul 29, 2024

Conversation

wmertens
Copy link
Member

When using capacitor, the "browser" is on capacitor://localhost or http://localhost, and
when route loading is proxied, the return URL origin is not the same as the current
origin. This prompted qwik-city to reload the page.

Now, this is only done when the request was actually redirected.

When using capacitor, the "browser" is on capacitor://localhost or http://localhost, and
when route loading is proxied, the return URL origin is not the same as the current
origin. This prompted qwik-city to reload the page.

Now, this is only done when the request was actually redirected.
@wmertens wmertens requested a review from a team as a code owner July 29, 2024 15:21
@wmertens wmertens enabled auto-merge (squash) July 29, 2024 15:21
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 877b81f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "qwik-monorepo" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link
Contributor

github-actions bot commented Jul 29, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 877b81f

Copy link

pkg-pr-new bot commented Jul 29, 2024

commit: 877b81f

npm i https://pkg.pr.new/@builder.io/qwik@6740
npm i https://pkg.pr.new/@builder.io/qwik-city@6740
npm i https://pkg.pr.new/eslint-plugin-qwik@6740
npm i https://pkg.pr.new/create-qwik@6740

Open in Stackblitz

@wmertens wmertens merged commit f5aabb9 into main Jul 29, 2024
21 checks passed
@wmertens wmertens deleted the qc-redir branch July 29, 2024 15:34
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
maiieul added a commit to maiieul/qwik that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants