-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use own package.json for all packages #6715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d2a4ec The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
❌ Deploy Preview for qwik-insights failed.
|
f8b0142
to
05d9486
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
2f20e23
to
bf547d2
Compare
21f5724
to
5a46b7e
Compare
No longer create a package.json in the dist folders. Instead, use the ones that are already there. This way, `changeset` can be used to version and deploy the packages. Co-authored-by: Shai Reznik <[email protected]>
9056ba4
to
5826fda
Compare
1d24d7e
to
04220e6
Compare
commit:
|
- cache build and test results separately - ensure that all build commands go via pnpm
This was referenced Jul 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer create a package.json in the dist folders. Instead, use the ones that are already there. This way,
changeset
can be used to version and deploy the packages.We're temporarily ignoring qwik-react and qwik-worker until we can fix changesets which is bumping them even when not needed.