Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use own package.json for all packages #6715

Merged
merged 10 commits into from
Jul 26, 2024
Merged

chore: use own package.json for all packages #6715

merged 10 commits into from
Jul 26, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jul 22, 2024

No longer create a package.json in the dist folders. Instead, use the ones that are already there. This way, changeset can be used to version and deploy the packages.

We're temporarily ignoring qwik-react and qwik-worker until we can fix changesets which is bumping them even when not needed.

@wmertens wmertens requested review from a team as code owners July 22, 2024 15:56
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 4d2a4ec

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "qwik-monorepo" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for qwik-insights failed.

Name Link
🔨 Latest commit 4d2a4ec
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/66a3e5b357cdf10008c2f69d

@wmertens wmertens force-pushed the fix-changesets branch 3 times, most recently from f8b0142 to 05d9486 Compare July 22, 2024 21:38
Copy link
Contributor

github-actions bot commented Jul 22, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview affb3b1

@wmertens wmertens force-pushed the fix-changesets branch 3 times, most recently from 2f20e23 to bf547d2 Compare July 23, 2024 13:03
@wmertens wmertens requested a review from a team as a code owner July 23, 2024 13:03
@wmertens wmertens force-pushed the fix-changesets branch 13 times, most recently from 21f5724 to 5a46b7e Compare July 25, 2024 12:50
wmertens and others added 2 commits July 25, 2024 15:03
No longer create a package.json in the dist folders. Instead, use the
ones that are already there. This way, `changeset` can be used to
version and deploy the packages.

Co-authored-by: Shai Reznik <[email protected]>
@wmertens wmertens force-pushed the fix-changesets branch 3 times, most recently from 9056ba4 to 5826fda Compare July 25, 2024 17:24
@wmertens wmertens force-pushed the fix-changesets branch 2 times, most recently from 1d24d7e to 04220e6 Compare July 25, 2024 18:10
Copy link

pkg-pr-new bot commented Jul 25, 2024

commit: 2852f79

npm i https://pkg.pr.new/@builder.io/qwik@6715
npm i https://pkg.pr.new/@builder.io/qwik-city@6715
npm i https://pkg.pr.new/eslint-plugin-qwik@6715
npm i https://pkg.pr.new/create-qwik@6715

Open in Stackblitz

wmertens added 2 commits July 25, 2024 21:12
- cache build and test results separately
- ensure that all build commands go via pnpm
@shairez shairez merged commit a1444ab into main Jul 26, 2024
19 of 23 checks passed
@shairez shairez deleted the fix-changesets branch July 26, 2024 20:51
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants