Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwik-city): strip internal parameters for compare #6694

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Jul 16, 2024

Followup for #6410 and #6687
Fixes #6660
Fixes #6677

@wmertens wmertens requested a review from a team as a code owner July 16, 2024 16:03
Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: aa4527f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch
@builder.io/qwik-react Patch
@builder.io/qwik-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for qwik-insights failed.

Name Link
🔨 Latest commit aa4527f
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6698f0ce980d4400085904dd

Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa4527f
Status:🚫  Build failed.

View logs

@wmertens wmertens force-pushed the qc-strip-internals branch from 8d34161 to d245822 Compare July 16, 2024 16:10
Copy link

pkg-pr-new bot commented Jul 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 43e200a

@builder.io/qwik

npm i https://pkg.pr.new/@builder.io/qwik@6694

@builder.io/qwik-city

npm i https://pkg.pr.new/@builder.io/qwik-city@6694

eslint-plugin-qwik

npm i https://pkg.pr.new/eslint-plugin-qwik@6694

create-qwik

npm i https://pkg.pr.new/create-qwik@6694


templates

@shairez
Copy link
Contributor

shairez commented Jul 16, 2024

seems like a duplicate of #6687 no?

btw did you see this?
#6687 (comment)

@wmertens wmertens force-pushed the qc-strip-internals branch from d245822 to 43e200a Compare July 18, 2024 09:58
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great 👏 thanks @wmertens

@wmertens wmertens merged commit 5595af1 into main Jul 18, 2024
23 of 28 checks passed
@wmertens wmertens deleted the qc-strip-internals branch July 18, 2024 13:15
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
@shirotech
Copy link

Very nice, hope this can be released soon. Have been waiting for a specific fix for awhile in anticipation. Great work team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants