-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qwik-city): strip internal parameters for compare #6694
Conversation
🦋 Changeset detectedLatest commit: aa4527f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for qwik-insights failed.
|
8d34161
to
d245822
Compare
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
seems like a duplicate of #6687 no? btw did you see this? |
d245822
to
43e200a
Compare
43e200a
to
22c512d
Compare
22c512d
to
aa4527f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great 👏 thanks @wmertens
packages/qwik-city/middleware/request-handler/resolve-request-handlers.ts
Show resolved
Hide resolved
Very nice, hope this can be released soon. Have been waiting for a specific fix for awhile in anticipation. Great work team! |
Followup for #6410 and #6687
Fixes #6660
Fixes #6677