Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Use false as default for overwriting existing directory #201

Merged
merged 4 commits into from
Dec 30, 2024
Merged

🚸 Use false as default for overwriting existing directory #201

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ae6a9d
:pencil2: Update the directory name example
siguici Dec 30, 2024
3140e72
:children_crossing: Use `false` as default for overwriting existing d…
siguici Dec 30, 2024
25aa611
:children_crossing: No longer ask anything if the directory exists an…
siguici Dec 30, 2024
27aed1c
:recycle: Improve conditions
siguici Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 28 additions & 31 deletions libs/create-qwikdev-astro/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export class Application extends Program<Definition, Input> {
definition.destination === defaultDefinition.destination
? await this.scanString(
`Where would you like to create your new project? ${this.gray(
`(Use '.' or './' for current directory)`
`(Use '.' or 'qwik-astro-app' for current directory)`
)}`,
definition.destination
)
Expand All @@ -193,13 +193,16 @@ export class Application extends Program<Definition, Input> {
definition,
`Directory "./${resolveRelativeDir(
outDir
)}" already exists and is not empty. What would you like to overwrite it?`
)}" already exists and is not empty. What would you like to overwrite it?`,
false
))
: false;

const ask = !exists || add || force;

let adapter: Adapter;

if ((!add || force) && definition.adapter === defaultDefinition.adapter) {
if (ask && (!add || force) && definition.adapter === defaultDefinition.adapter) {
const adapterInput =
((await this.scanBoolean(
definition,
Expand Down Expand Up @@ -235,40 +238,34 @@ export class Application extends Program<Definition, Input> {
adapter = definition.adapter;
}

const biome =
!add && definition.biome === undefined
? !!(await this.scanBoolean(
definition,
"Would you prefer Biome over ESLint/Prettier?"
))
: !!definition.biome;
const biome = !!(ask && !add && definition.biome === undefined
? await this.scanBoolean(definition, "Would you prefer Biome over ESLint/Prettier?")
: definition.biome);

const ci =
definition.ci === undefined
? !!(await this.scanBoolean(definition, "Would you like to add CI workflow?"))
: definition.ci;
const ci = !!(ask && definition.ci === undefined
? await this.scanBoolean(definition, "Would you like to add CI workflow?")
: definition.ci);

const install =
definition.install === undefined
? !!(await this.scanBoolean(
definition,
`Would you like to install ${this.#packageManger} dependencies?`
))
: definition.install;
const install = !!(ask && definition.install === undefined
? await this.scanBoolean(
definition,
`Would you like to install ${this.#packageManger} dependencies?`
)
: definition.install);

const git =
definition.git === undefined
? !!(await this.scanBoolean(definition, "Would you like to initialize Git?"))
: definition.git;
const git = !!(ask && definition.git === undefined
? await this.scanBoolean(definition, "Would you like to initialize Git?")
: definition.git);

const dryRun = !!definition.dryRun;

packageName = definition.yes
? packageName
: await this.scanString(
"What should be the name of this package?",
exists && !force ? (getPackageJson(outDir).name ?? packageName) : packageName
);
packageName =
!ask || definition.yes
? packageName
: await this.scanString(
"What should be the name of this package?",
exists && !force ? (getPackageJson(outDir).name ?? packageName) : packageName
);

return {
destination,
Expand Down
Loading