Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add IDE extension for i18n handling #1896

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

NilsJacobsen
Copy link
Contributor

let me know what needs to be changed in order to merge this

Description: DX upgrade with little i18n tool.

What I added (opt-in)

  • A config file -> settings.json
  • Vscode recommendation so the contributors can use the extension

Screenshots:

IDE-Extension:
image

Editor:
image

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 14, 2023
@NilsJacobsen
Copy link
Contributor Author

Btw, there is also a cli. Let me know if I can help integrating that.

@mamadoudicko
Copy link
Contributor

Nice contrib! Thanks @NilsJacobsen

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 14, 2023
@mamadoudicko mamadoudicko changed the title [improvement] add ide extension for i18n handling chore: add IDE extension for i18n handling Dec 14, 2023
@mamadoudicko mamadoudicko merged commit 992c67a into QuivrHQ:main Dec 14, 2023
@felixhaeberle
Copy link

Happy to see this merged!! 😍🎉

StanGirard added a commit that referenced this pull request Dec 14, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.140 (2023-12-14)

## What's Changed
* feat: Update pytest command in Makefile and add new test by
@StanGirard in #1893
* chore: add IDE extension for i18n handling by @NilsJacobsen in
#1896
* feat: add chat view new design by @mamadoudicko in
#1897

## New Contributors
* @NilsJacobsen made their first contribution in
#1896

**Full Changelog**:
v0.0.139...v0.0.140

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
StanGirard pushed a commit that referenced this pull request Dec 14, 2023
…1899)

> Follow up to #1896

# Improved Docs 

I added this to get more translation contributions.

## What I changed
- Added a `Translation` section in the contribution guidelines
- Added a link to it in the contribution guidelines table of contents
- Added a link from Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants