Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): use multi-stage Docker builds for smaller images #1614

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

shidenkai0
Copy link
Contributor

@shidenkai0 shidenkai0 commented Nov 12, 2023

Description

Currently, the production Docker images are very large, sitting at 4.17 GB for the frontend image, and 3.49 GB for backend images. This change adds multi-stage builds, to optimize the image sizes, which results in the following improvements:

  • frontend image size: 4.17 GB -> 1.64 GB
  • backend image size: 3.49 GB -> 1.71 GB

I hope this is appropriate as there is no open issue for this that I know of.
I implemented this change and tested it locally, and would be glad to discuss this and open an issue if necessary.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • New and existing unit tests pass locally with my changes

Screenshots (if appropriate):

Image sizes before:
image

Image sizes after:
image

Copy link

vercel bot commented Nov 12, 2023

@shidenkai0 is attempting to deploy a commit to the Quivr-app Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 12, 2023
Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 5:32pm

Copy link
Contributor

@gozineb gozineb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks a lot @shidenkai0 !

@gozineb gozineb merged commit 71d4a63 into QuivrHQ:main Nov 13, 2023
mamadoudicko pushed a commit that referenced this pull request Nov 13, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.109 (2023-11-13)

## What's Changed
* feat: add APIBrainQA by @mamadoudicko in
#1606
* feat: allow users to chat with apis by @mamadoudicko in
#1612
* feat(docker): use multi-stage Docker builds for smaller images by
@shidenkai0 in #1614

## New Contributors
* @shidenkai0 made their first contribution in
#1614

**Full Changelog**:
v0.0.108...v0.0.109

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.109 (2023-11-13)

## What's Changed
* feat: add APIBrainQA by @mamadoudicko in
QuivrHQ/quivr#1606
* feat: allow users to chat with apis by @mamadoudicko in
QuivrHQ/quivr#1612
* feat(docker): use multi-stage Docker builds for smaller images by
@shidenkai0 in QuivrHQ/quivr#1614

## New Contributors
* @shidenkai0 made their first contribution in
QuivrHQ/quivr#1614

**Full Changelog**:
QuivrHQ/quivr@v0.0.108...v0.0.109

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants