feat: add name missing error in new brain modal

[mamadoudicko]

Description

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 7:53am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 7:53am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/AddBrainModal/hooks/useAddBrainModal.ts

The code changes in this file are generally good, but there are a few areas that could be improved for better readability and maintainability.

1. Error handling: The error handling in the handleSubmit function could be improved. Currently, the error message is directly converted to a string and displayed to the user. This could potentially expose sensitive information. It would be better to have a predefined error message for known errors and a generic error message for unknown errors.

if (axios.isAxiosError(err) && err.response?.status === 429) {
  publish({
    variant: \"danger\",
    text: t(\"errorRateLimitExceeded\", { ns: \"config\" }),
  });
} else {
  publish({
    variant: \"danger\",
    text: t(\"errorUnknown\", { ns: \"config\" }),
  });
}

2. Use of trim function: The trim function is used multiple times in the code. It would be better to create a helper function that trims the input and checks if it's empty. This would make the code cleaner and more maintainable.

const isNotEmpty = (input: string) => input.trim() !== \"\";

if (isNotEmpty(name) || isPending) {
  // ...
}

3. Use of useState: The useState hook is used multiple times in the code. It would be better to use the useReducer hook instead when dealing with complex state logic that involves multiple sub-values or when the next state depends on the previous one. This would make the code more predictable and easier to test.

---

🔒💡🔄

---

Powered by Code Review GPT