-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update header and remove prompt / brain on backspace #1052
Conversation
mamadoudicko
commented
Aug 28, 2023
- Update header turn setting icon into brain icon and remove brain dropdown
- Remove selected prompt / brain on backspace
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/invitation/[brainId]/hooks/useInvitation.ts The function Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/BrainUsers/components/BrainUser/hooks/useBrainUser.ts The error handling could be improved. Currently, the error message is directly displayed to the user. It would be better to have a more user-friendly message and log the actual error for debugging. For example: if (axiosError !== undefined && axiosError.status === 403) {
publish({
variant: \"danger\",
text: t(\"userRoleUpdateFailed\", { email: email, role: newRole, ns: \"brain\" }),
});
console.error(axiosError.message);
} else {
publish({
variant: \"danger\",
text: t(\"userRoleUpdateFailed\", { email: email, role: newRole, ns: \"brain\" }),
});
console.error(e);
} Risk Level 3 - /home/runner/work/quivr/quivr/frontend/lib/hooks/useShareBrain.ts
const isMounted = useRef(true);
useEffect(() => {
return () => {
isMounted.current = false;
};
}, []);
// Then, in your async function:
if (isMounted.current) {
setSendingInvitation(false);
}
} catch (error) {
if (axios.isAxiosError(error)) {
// Handle Axios errors
} else {
// Handle network errors
}
} 📚🔧 Powered by Code Review GPT |
68f4c6f
to
c4d2e5a
Compare
c4d2e5a
to
3f6f685
Compare
3f6f685
to
96cc3cd
Compare
I miss your loom videos mamadou 😭 |
96cc3cd
to
819a14d
Compare
adb269d
to
434ac3c
Compare
* feat: update header * feat: remove selected prompt / brain on backspace * feat(chat): update suggestions component * refactor: add getAxiosErrorParams