-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(backend): skip failing tests #1036
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/backend/models/files.py The changes in this file involve calling methods on Risk Level 2 - /home/runner/work/quivr/quivr/backend/routes/chat_routes.py The changes in this file involve modifying the default values for the Risk Level 3 - /home/runner/work/quivr/quivr/backend/llm/qa_base.py The changes in this file involve adding type ignore comments and making several changes to the way the code interacts with the vector store and the qa object. These changes could potentially cause issues if the ignored types cause unexpected behavior or if the changes to the vector store and qa object interactions are not handled correctly. Consider adding checks to ensure the types are as expected and thoroughly testing the new interactions with the vector store and qa object. 🔍🐞🧪 Powered by Code Review GPT |
dc1504b
to
4d06aa2
Compare
4d06aa2
to
08d9888
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
The objective of this PR is to guarantee the successful execution of backend CI tests. Our current challenge involves a growing count of test failures. This is compounded by instances where a single test failure goes unnoticed, subsequently triggering more test failures down the line. To address this issue, we need to enhance our CI monitoring and maintenance practices. It's crucial to emphasize that, moving forward, any CI test failures are likely to be significant and indicative of underlying problems requiring resolution.
Furthermore, it's important to note that adding skip instructions directly to the codebase should be avoided. Such instructions can obscure genuine issues and prevent the identification of actual problems within the code.