Prepend slash to service ID in DELETE #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small discrepancy in the current bamboo version in handling the ID between PUT and DELETE.
Create service
/some/service
using PUT:Delete same service:
This is because PUT and POST read the service-ID from the JSON payload and prepend a slash if the ID does not start with one. This fix just also adds the slash when using the DELETE request.
I noticed that there is also no input validation on the ID read from JSON, so if an empty string is passed it is converted to a single slash, which should probably also not happen.