Fix issue in finding debugsymbols for Fedora 41 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it also QubesOS/qubes-issues#9137 ? |
marmarek
reviewed
May 18, 2024
rpm-oxide.spec.in
Outdated
| @@ -29,7 +29,7 @@ BuildRequires: rpm-devel >= 4.14.2.1-4 | |||
| BuildRequires: rust-debugger-common | |||
| BuildRequires: rust-cc-devel | |||
| BuildRequires: rust-libc-devel | |||
| %define qubes_cargo RUSTFLAGS='-Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now' \\\ | |||
| %define qubes_cargo RUSTFLAGS='-Cstrip=none -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now' \\\ | |||
There was a problem hiding this comment.
Maybe better avoid setting custom RUSTFLAGS at all?
And add %set_build_flags at the start of %build (and %check?) to have default ones set
There was a problem hiding this comment.
@DemiMarie what's the original reason to not use default Fedora flags?
There was a problem hiding this comment.
I don’t remember. I suspect it dates back to me trying to support the ancient Rust in Fedora 25 for R4.0.
There was a problem hiding this comment.
@fepitre so, in this case can you try removing custom RUSTFLAGS?
Build typically fails like: ``` + /usr/bin/find-debuginfo -j8 --strict-build-id -m -i --build-id-seed 0.2.7-1.fc41 --unique-debug-suffix -0.2.7-1.fc41.x86_64 --unique-debug-src-base qubes-rpm-oxide-0.2.7-1.fc41.x86_64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 110000000 -S debugsourcefiles.list /builddir/build/BUILD/qubes-rpm-oxide-0.2.7 find-debuginfo: starting Extracting debug info from 2 files warning: Unsupported auto-load script at offset 0 in section .debug_gdb_scripts of file /builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/sigparse. Use `info auto-load python-scripts [REGEXP]' to list them. warning: Unsupported auto-load script at offset 0 in section .debug_gdb_scripts of file /builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/rpmcanon. Use `info auto-load python-scripts [REGEXP]' to list them. Error while writing index for `/builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/sigparse': No debugging symbols Error while writing index for `/builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/rpmcanon': No debugging symbols gdb-add-index: No index was created for /builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/sigparse gdb-add-index: [Was there no debuginfo? Was there already an index?] gdb-add-index: No index was created for /builddir/build/BUILDROOT/qubes-rpm-oxide-0.2.7-1.fc41.x86_64/usr/bin/rpmcanon gdb-add-index: [Was there no debuginfo? Was there already an index?] DWARF-compressing 2 files dwz: Too few files for multifile optimization sepdebugcrcfix: Updated 0 CRC32s, 2 CRC32s did match. Creating .debug symlinks for symlinks to ELF files find-debuginfo: done ```
|
I'm confused, now fc38 failed with: but both fc37 (dom0) and fc39 worked |
|
I have an idea: Fedora 38 went EOL just a few days ago, lets drop it from CI :D |
|
PipelineRetry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build typically fails like:
https://doc.rust-lang.org/cargo/reference/profiles.html#strip
QubesOS/qubes-issues#9244