Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved design of Global Settings #300

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

marmarta
Copy link
Member

@marmarta marmarta commented Sep 8, 2021

Transitional form: the functionality is the same, changes are
mostly visual, with only a minor addition of Version no,
release info link and version link.

fixes QubesOS/qubes-issues#6858

@marmarek
Copy link
Member

Font sizes here are huge, it barely fits on the screen (and I got a scrollbar). Can you use the same font size as in the manager? I've just checked - it does use whatever you set in global appearance settings, so probably it will be enough to simply not override it with any explicit value.

And also - I don't like the new buttons at the bottom, because:

  • they are in different place than in every other dialog
  • they have only text and no graphical (or color) indicator of the action - again contrary to every other dialog in the system

@marmarta
Copy link
Member Author

marmarta commented Oct 7, 2021

@marmarek , I pushed a better, improved version. Could you check if it's still super big on a system that's not custom-dpi-ed to hell?

@marmarta
Copy link
Member Author

@marmarek , could you check if this looks better on your end? Looks good on mine but as we established, well, this means little.

Transitional form: the functionality is the same, changes are
mostly visual, with only a minor addition of Version no,
release info link and version link.

fixes QubesOS/qubes-issues#6858
@marmarek marmarek merged commit dad40de into QubesOS:master Oct 14, 2021
@marmarek marmarek mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX Improvement Nits: 4.1 Settings screen
2 participants