Update Qt version used in qubesmanager to Qt5 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
May 30, 2019
qubesmanager/firewall.py
Outdated
| self.tr("You need to fill service " | ||
| "name/port for TCP/UDP rule")) | ||
| return | ||
| QtGui.QDialog.accept(self) | ||
| QtWidgets.QDialog.accept(self) |
There was a problem hiding this comment.
I think this should be super().accept()
qubesmanager/log_dialog.py
Outdated
|
|
||
| self.__init_log_text__() | ||
|
|
||
| def __init_log_text__(self): | ||
| print(self.log_path) |
qubesmanager/log_dialog.py
Outdated
| @@ -62,16 +63,18 @@ def __init_log_text__(self): | |||
| else: | |||
| log.seek(0, os.SEEK_SET) | |||
| self.displayed_text += log.read() | |||
| print(self.displayed_text) | |||
qubesmanager/restore.py
Outdated
| @@ -35,8 +34,7 @@ | |||
| from . import multiselectwidget | |||
| from . import backup_utils | |||
|
|
|||
| from multiprocessing import Queue | |||
| from multiprocessing.queues import Empty | |||
| import queue | |||
There was a problem hiding this comment.
queue.Queue is different from multiprocessing.Queue. According to documentation, the former works with threads, but not necessary with processes. Any specific reason for this change?
Fixed dependencies, places where obsolete functions stopped working, code fragments that started throwing warnings and an .ui file that stopped being readable after the update.
marmarek
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed dependencies, places where obsolete functions stopped working,
code fragments that started throwing warnings and an .ui file that
stopped being readable after the update.