Added "set as dvm template" to VM settings #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
Feb 11, 2019
qubesmanager/settings.py
Outdated
| self.vm.template_for_dispvms = \ | ||
| self.dvm_template_checkbox.isChecked() | ||
| self.vm.features["appmenus-dispvm"] = \ | ||
| 1 if self.dvm_template_checkbox.isChecked() else "" |
There was a problem hiding this comment.
In case of disabling this setting, I'd remove appmenus-dispvm feature, instead of setting it to false.
BTW setting features to bool values is supported - they will be converted to appropriate values (1, empty) preserving true/false semantics.
marmarta
force-pushed
the
bugfix4004
branch
2 times, most recently
from
994bff0 to
011d9df
Compare
marmarek
reviewed
Feb 13, 2019
ui/settingsdlg.ui
Outdated
| <string/> | ||
| </property> | ||
| <property name="text"> | ||
| <string>Allow starting Disposable VMs from this qube</string> |
There was a problem hiding this comment.
This is yet another example why we need to settle on a solid definitions of VM vs Qube. I'll comment on QubesOS/qubes-issues#1015
Added an 'Advanced' settings checkbox that allows the user to set a given VM as template fo dispvms. It sets both the template_for_dispvms property and the appmenus-dispvm feature - instead of delving into particulars of how and which should be set, the user can just turn off the whole setting if they want to make some changes in the vm and then turn it on again. fixes QubesOS/qubes-issues#4004
marmarek
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an 'Advanced' settings checkbox that allows the user to set a given
VM as template fo dispvms. It sets both the template_for_dispvms property
and the appmenus-dispvm feature - instead of delving into particulars
of how and which should be set, the user can just turn off the
whole setting if they want to make some changes in the vm and then turn
it on again.
fixes QubesOS/qubes-issues#4004