Skip to content

Commit

Permalink
Add tooltip to application list in VM settings
Browse files Browse the repository at this point in the history
The 'Comment' field will now be displayed as a tooltip in VM settings.
Requires QubesOS/qubes-desktop-linux-common#12

references QubesOS/qubes-issues#5076
  • Loading branch information
marmarta committed Jun 10, 2019
1 parent 492b870 commit 4567707
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions qubesmanager/appmenu_select.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,16 @@
# TODO icon
# pylint: disable=too-few-public-methods
class AppListWidgetItem(PyQt4.QtGui.QListWidgetItem):
def __init__(self, name, ident, parent=None):
def __init__(self, name, ident, tooltip=None, parent=None):
super(AppListWidgetItem, self).__init__(name, parent)
# self.setToolTip(command)
if tooltip:
self.setToolTip(tooltip)
self.ident = ident

@classmethod
def from_line(cls, line):
ident, _icon_name, name = line.strip().split(maxsplit=2)
return cls(name=name, ident=ident)
ident, name, comment = line.split('|', maxsplit=3)
return cls(name=name, ident=ident, tooltip=comment)


class AppmenuSelectManager:
Expand All @@ -58,9 +59,10 @@ def fill_apps_list(self):
self.app_list.clear()

available_appmenus = [AppListWidgetItem.from_line(line)
for line in subprocess.check_output(['qvm-appmenus',
'--get-available', '--i-understand-format-is-unstable',
self.vm.name]).decode().splitlines()]
for line in subprocess.check_output(
['qvm-appmenus', '--get-available',
'--i-understand-format-is-unstable', '--file-field',
'Comment', self.vm.name]).decode().splitlines()]

for app in available_appmenus:
if app.ident in self.whitelisted:
Expand Down

0 comments on commit 4567707

Please sign in to comment.