-
-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
70 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
From: Jan Beulich <[email protected]> | ||
Subject: xen-blkback: fix error handling in xen_blkbk_map() | ||
|
||
The function uses a goto-based loop, which may lead to an earlier error | ||
getting discarded by a later iteration. Exit this ad-hoc loop when an | ||
error was encountered. | ||
|
||
The out-of-memory error path additionally fails to fill a structure | ||
field looked at by xen_blkbk_unmap_prepare() before inspecting the | ||
handle which does get properly set (to BLKBACK_INVALID_HANDLE). | ||
|
||
Since the earlier exiting from the ad-hoc loop requires the same field | ||
filling (invalidation) as that on the out-of-memory path, fold both | ||
paths. While doing so, drop the pr_alert(), as extra log messages aren't | ||
going to help the situation (the kernel will log oom conditions already | ||
anyway). | ||
|
||
This is XSA-365. | ||
|
||
Reported-by: Bjoern Doebel <[email protected]> | ||
Signed-off-by: Jan Beulich <[email protected]> | ||
Reviewed-by: Juergen Gross <[email protected]> | ||
Reviewed-by: Julien Grall <[email protected]> | ||
--- | ||
v2: Avoid overwriting valid ->persistent_gnt fields. | ||
|
||
--- a/drivers/block/xen-blkback/blkback.c | ||
+++ b/drivers/block/xen-blkback/blkback.c | ||
@@ -793,8 +793,11 @@ again: | ||
pages[i]->page = persistent_gnt->page; | ||
pages[i]->persistent_gnt = persistent_gnt; | ||
} else { | ||
- if (get_free_page(ring, &pages[i]->page)) | ||
- goto out_of_memory; | ||
+ if (get_free_page(ring, &pages[i]->page)) { | ||
+ put_free_pages(ring, pages_to_gnt, segs_to_map); | ||
+ ret = -ENOMEM; | ||
+ goto out; | ||
+ } | ||
addr = vaddr(pages[i]->page); | ||
pages_to_gnt[segs_to_map] = pages[i]->page; | ||
pages[i]->persistent_gnt = NULL; | ||
@@ -880,17 +885,18 @@ next: | ||
} | ||
segs_to_map = 0; | ||
last_map = map_until; | ||
- if (map_until != num) | ||
+ if (!ret && map_until != num) | ||
goto again; | ||
|
||
- return ret; | ||
- | ||
-out_of_memory: | ||
- pr_alert("%s: out of memory\n", __func__); | ||
- put_free_pages(ring, pages_to_gnt, segs_to_map); | ||
- for (i = last_map; i < num; i++) | ||
+out: | ||
+ for (i = last_map; i < num; i++) { | ||
+ /* Don't zap current batch's valid persistent grants. */ | ||
+ if(i >= last_map + segs_to_map) | ||
+ pages[i]->persistent_gnt = NULL; | ||
pages[i]->handle = BLKBACK_INVALID_HANDLE; | ||
- return -ENOMEM; | ||
+ } | ||
+ | ||
+ return ret; | ||
} | ||
|
||
static int xen_blkbk_map_seg(struct pending_req *pending_req) |