Opening app menu via keyboard shortcut opens it under the cursor

[andrewdavidwong]

How to file a helpful issue

Qubes OS release

4.2

Brief summary

Opening app menu via keyboard shortcut opens it under the cursor instead of the normal location.

Steps to reproduce

Assign app menu to a keyboard shortcut. Press that keyboard shortcut.

Expected behavior

App menu opens in same location as if you had clicked the button to open it.

Actual behavior

App menu opens under cursor, e.g., in the middle of the screen, unattached from panel.

[UndeadDevel]

Related to #9005

[rustybird]

I thought the current behavior was intentional, isn't it convenient for mouse users?

https://github.com/QubesOS/qubes-desktop-linux-menu/blob/v1.1.5/qubes_menu/qubes-menu.glade#L8

[bi0shacker001]

I thought the current behavior was intentional, isn't it convenient for mouse users?

https://github.com/QubesOS/qubes-desktop-linux-menu/blob/v1.1.5/qubes_menu/qubes-menu.glade#L8

That behavior is one of the primary reasons I wouldn't run qubes if I were forced into xfce. Even if it's convenient for mouse users, it's a huge PITA for keyboard-shortcut users (pressing enter will select whatever is under the mouse cursor, not the first option, which breaks pseudo-autocomplete, for instance)

[alimirjamali]

The current default position is set to mouse in the Glade file:

https://github.com/QubesOS/qubes-desktop-linux-menu/blob/main/qubes_menu/qubes-menu.glade#L8

A new command line option could be added to set the position (e.g. --position POSITION). Default could be mouse to keep the existing behaviour. User could set the position to top-left, center, ...

[alimirjamali]

Another approach could be depending on a feature to set the menu position. Just like how app_page feature is currently used to set the default Tab/Page.

Both approaches are easy to implement.

@marmarta Is it OK to add a command line option or feature to allow users to set the Appmenu position? (rather than at mouse position). I can work on it.

[marmarta]

I think a feature is the best approach - it can be changed while the menu is running, for example.

[alimirjamali]

Choices of icons and text for Qubes Menu Settings:

[alimirjamali]

PR Submitted

Review priority: Low

I will work on the relevant unittests if the change is good.

[alimirjamali]

This needs a final touch. Currently assigning qubes-app-menu to Super/Start key will open the Appmenu. But pressing it again does not hide it (it closes it and reopens it).

p.s.: I believe I have a clear idea on this bug. It happens since program loses focus on 2nd Hotkey press and _focus_out is executed before do_activate. It is necessary to find a workaround

[andrewdavidwong]

Choices of icons and text for Qubes Menu Settings:

What do "left," "right," and "center" mean? My expectation of "normal" behavior would be for the app menu to be attached to the button on the panel that opens it.

This needs a final touch. Currently assigning qubes-app-menu to Super/Start key will open the Appmenu. But pressing it again does not hide it (it closes it and reopens it).

This sounds familiar, but I can't find an issue for it. I suggest opening a separate issue for it (unless you can find an existing one).

[alimirjamali]

What do "left," "right," and "center" mean? My expectation of "normal" behavior would be for the app menu to be attached to the button on the panel that opens it.

Top-Left, top-right or top-center of the screen. Or under the current mouse position. Since the menu height is set to (around) screen height, there is no need to set the vertical position. I assume most users will use either left or mouse options.

Attaching the Appmenu to the exact position of the button on the panel is much harder than it sounds. It requires a real Xfce plugin (work in progress for #2136).

This sounds familiar, but I can't find an issue for it. I suggest opening a separate issue for it (unless you can find an existing one).

Yes. Exactly.

[andrewdavidwong]

Top-Left, top-right or top-center of the screen. Or under the current mouse position.

But my panel is on the bottom of my screen, not the top.

Since the menu height is set to (around) screen height, there is no need to set the vertical position.

My menu currently takes up only about half of my screen height.

Attaching the Appmenu to the exact position of the button on the panel is much harder than it sounds. It requires a real Xfce plugin (work in progress for #2136).

Okay, fair enough.

[alimirjamali]

My menu currently takes up only about half of my screen height.

Oh. I see. Now that I look again at code, the 0.9x resize only downsizes the menu, not expand it.

So the positions could be Top-Left, Top-Right, Bottom-Left, Bottom-right and mouse position. Now that I reconsider it, adding option for centring menu vertically or horizontally is useless. Hope everyone agrees with it.