Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the units and tooltip in "Private storage max size" #8889

Closed
emanruse opened this issue Jan 26, 2024 · 5 comments · Fixed by QubesOS/qubes-manager#379
Closed

Correct the units and tooltip in "Private storage max size" #8889

emanruse opened this issue Jan 26, 2024 · 5 comments · Fixed by QubesOS/qubes-manager#379
Assignees
Labels
C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. ux User experience

Comments

@emanruse
Copy link

emanruse commented Jan 26, 2024

The problem you're addressing (if any)

The tooltip for "Private storage max size" in qube Settings GUI seems a useless explanation of the wrong choice of units.

The solution you'd like

Instead of the tooltip for "Private storage max size", explaining the "binary definition of megabyte and gigabyte", simply use the proper units - mebibyte (MiB) or gebibyte (GiB).

Also make that consistent with the units for memory in Advanced tab.

The value to a user, and who that user might be

A clear, straightforward and correct unit, instead of explanations for a wrong one.

@emanruse emanruse added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement labels Jan 26, 2024
@andrewdavidwong andrewdavidwong added C: manager/widget P: minor Priority: minor. The lowest priority, below "default." ux User experience and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Feb 1, 2024
@marmarta marmarta removed their assignment Mar 6, 2024
@alimirjamali
Copy link

Related: #7889

@alimirjamali
Copy link

PR Submitted.

Minor fix mostly for cosmetic purposes.
Review priority: Low

p.s.: The fix for memory units (and others) will come for #7889

@ben-grande
Copy link

The qvm-prefs manual still reports memory unit as MB (Megabyte) and not MiB (Mebibyte). Should this issue be reopened or a new one created?

@alimirjamali
Copy link

The qvm-prefs manual still reports memory unit as MB (Megabyte) and not MiB (Mebibyte). Should this issue be reopened or a new one created?

I submitted the required fix (also for qvm-ls code comment). A minor change.

@marmarta
Copy link
Member

marmarta commented Jan 6, 2025

The fix was merged, this can be safely closed again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. ux User experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants