Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qube Manager 4.2.0 Release Notes stale, incomplete #8803

Closed
Martin-Buchholz opened this issue Dec 28, 2023 · 4 comments · Fixed by QubesOS/qubes-manager#385
Closed

Qube Manager 4.2.0 Release Notes stale, incomplete #8803

Martin-Buchholz opened this issue Dec 28, 2023 · 4 comments · Fixed by QubesOS/qubes-manager#385
Assignees
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: doc C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.

Comments

@Martin-Buchholz
Copy link

Fresh install of 4.2.0
dom0: Qube Manager -> About -> Release Notes
shows "Qubes R4.1 release notes" and is incomplete.
Appears to show the contents of
/usr/share/doc/qubes-release-notes/README.Qubes-Release-Notes

If release notes refresh is too much work to automate,
I suggest dropping the "Release Notes" button in the GUI or just leaving a reference to
https://www.qubes-os.org/doc/releases/4.2/release-notes/
or
https://www.qubes-os.org/doc/releases/notes/
which appear well maintained.

@Martin-Buchholz Martin-Buchholz added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Dec 28, 2023
@andrewdavidwong andrewdavidwong added C: manager/widget C: doc affects-4.2 This issue affects Qubes OS 4.2. labels Dec 28, 2023
@andrewdavidwong andrewdavidwong added the diagnosed Technical diagnosis has been performed (see issue comments). label Dec 28, 2023
@marmarta marmarta removed their assignment Mar 6, 2024
@alimirjamali
Copy link

Title should read: Qube Manager 4.2.0 Release Notes stale, incomplete

The file in question is from qubes-qubes-release repo.

The suggested update is from qubes-doc repo.

If release notes refresh is too much work to automate,
I suggest dropping the "Release Notes" button in the GUI or just leaving a reference to
https://www.qubes-os.org/doc/releases/4.2/release-notes/
or
https://www.qubes-os.org/doc/releases/notes/
which appear well maintained.

Since the README.md file does not render nice in Qube Manager, the above suggestion sounds reasonable. For the actual file, maybe dropping it from qubes-qubes-release would be better than keeping an unmaintained off-line version. Most users would use a search engine to find the online version.

@alimirjamali
Copy link

PR Submitted.

Review priority: low

This complies with overall trend of breaking Qube Manager to smaller and manageable units. If the release notes is to be added again, I believe Global Config or even a new small App would be a better option.

I have not submitted the supplementary PR to remove the stale text file from qubes-qubes-release repo. Awaiting overall decision.

@andrewdavidwong andrewdavidwong changed the title 4.2.0 Release Notes stale, incomplete Qube Manager 4.2.0 Release Notes stale, incomplete Sep 4, 2024
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Sep 4, 2024
@andrewdavidwong andrewdavidwong added the S: question Status: question. In order to determine the status of this issue, an open question must be answered. label Sep 4, 2024
@alimirjamali
Copy link

@marmarek What to do with the stale /usr/share/doc/qubes-release-notes/README.Qubes-Release-Notes file? I could think of the below possibilities:

  1. Delete it from qubes-qubes-release repo.
  2. Keep multiple versions per release tag.
  3. Keep just one version with link to the website.

@andrewdavidwong
Copy link
Member

@marmarek What to do with the stale /usr/share/doc/qubes-release-notes/README.Qubes-Release-Notes file? I could think of the below possibilities:

  1. Delete it from qubes-qubes-release repo.
  2. Keep multiple versions per release tag.
  3. Keep just one version with link to the website.

@alimirjamali, perhaps you should make a separate issue for this.

@andrewdavidwong andrewdavidwong removed the S: question Status: question. In order to determine the status of this issue, an open question must be answered. label Sep 28, 2024
alimirjamali added a commit to alimirjamali/qubes-qubes-release that referenced this issue Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: doc C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants