Critical error in Qube Manager after enabling "Allow full access for 5 mins"

[Eric678]

Qubes OS release

R4.1 & R4.2 - much more prevalent in 4.2

Brief summary

Enabling the "Allow full access for 5 mins" option results in a critical error the next time the qube's settings are opened within the five-minute window.

Steps to reproduce

1. In the "Firewall rules" tab of a qube's Settings, select "Limit outgoing connections to..." and "Allow full access for 5 mins."
2. Press "OK."
3. Within the next five minutes, attempt to open the settings for that qube again.

Expected behavior

Qube Settings opens normally.

Actual behavior

Full log in that error window:

----
line: expire_time = model.temp_full_access_expire_time - \
func: set_fw_model
line no.: 1464
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: self.set_fw_model(model)
func: __init__
line no.: 192
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: window = window_class(qt_app, qubes_app)
func: run_synchronous
line no.: 558
file: /usr/lib/python3.11/site-packages/qubesmanager/utils.py
----
line: utils.run_synchronous(functools.partial(VMSettingsWindow, vm, args.tab))
func: main
line no.: 1540
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: sys.exit(load_entry_point('qubesmanager==4.2.8', 'console_scripts', 'qubes-vm-settings')())
func: <module>
line no.: 33
file: /usr/bin/qubes-vm-setting

[Eric678]

Update: the problem with the immediate Houston popup when requesting settings rectifies itself eventually, probably when the timer expires. Don't need to restart the qube.

BTW the reason I used "[dom0] Houston, we have a problem..." as the title of this issue is that is the title of the error dialogue that appears, and what someone would search for.

[jaydn]

I just experienced I think a variant of this on 4.2. In this case it was:

TypeError: unsupported operand type(s) for -: 'int' and 'str'
at line 33
of file /usr/bin/qubes-vm-settings.

I was able to workaround by commenting out the bottom 2 lines of func, opening Qube Manager, removing all firewall entries & disabling "allow full access". I could then uncomment the lines and all good.

Here is the more detailed information from the dom0 popup.

----
line: expire_time = model.temp_full_access_expire_time - \
func: set_fw_model
line no.: 1464
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: self.set_fw_model(model)
func: __init__
line no.: 192
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: window = window_class(qt_app, qubes_app)
func: run_synchronous
line no.: 558
file: /usr/lib/python3.11/site-packages/qubesmanager/utils.py
----
line: utils.run_synchronous(functools.partial(VMSettingsWindow, vm, args.tab))
func: main
line no.: 1540
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: sys.exit(load_entry_point('qubesmanager==4.2.8', 'console_scripts', 'qubes-vm-settings')())
func: <module>
line no.: 33
file: /usr/bin/qubes-vm-settings

[UndeadDevel]

This seems like a duplicate of #8757 but that is supposed to be fixed now...Edit2: it's not fixed, can still reproduce.
Edit: or rather my linked issue is a duplicate of this one, which I didn't see when I opened it, as this one was opened earlier.

Edit3: the manager version that fixes this is not yet in stable as I just saw (I got confused by the stable labels in the linked issue). So presumably updating with testing repo enabled should fix this issue.

[andrewdavidwong]

This seems like a duplicate of #8757 but that is supposed to be fixed now...Edit2: it's not fixed, can still reproduce. Edit: or rather my linked issue is a duplicate of this one, which I didn't see when I opened it, as this one was opened earlier.

Edit3: the manager version that fixes this is not yet in stable as I just saw (I got confused by the stable labels in the linked issue). So presumably updating with testing repo enabled should fix this issue.

Ordinarily, you're correct that we would close #8757 (the newer issue) as a duplicate of #8685 (the older issue). However, since #8757 is already closed as fixed, and the commits are associated with #8757, we can close #8685 as a duplicate instead.

[Eric678]

This issue is not yet fixed! I only just caught up to date and checked. Firewall tab in settings with "Limit outgoing connections.." set, and allow for 5 min ticked, then hit "OK" then this is the result of attempting to open the settings in that qube until the timer expires:

[UndeadDevel]

This issue is not yet fixed!

Can confirm and reproduce with the same method as @Eric678 and same result. Full log in that error window:

----
line: expire_time = model.temp_full_access_expire_time - \
func: set_fw_model
line no.: 1464
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: self.set_fw_model(model)
func: __init__
line no.: 192
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: window = window_class(qt_app, qubes_app)
func: run_synchronous
line no.: 558
file: /usr/lib/python3.11/site-packages/qubesmanager/utils.py
----
line: utils.run_synchronous(functools.partial(VMSettingsWindow, vm, args.tab))
func: main
line no.: 1540
file: /usr/lib/python3.11/site-packages/qubesmanager/settings.py
----
line: sys.exit(load_entry_point('qubesmanager==4.2.8', 'console_scripts', 'qubes-vm-settings')())
func: <module>
line no.: 33
file: /usr/bin/qubes-vm-setting

[andrewdavidwong]

@Eric678, @UndeadDevel: It looks like you're commenting on the wrong issue. This issue (#8685) was closed as a duplicate of #8757, see #8685 (comment). You should comment on #8757 instead.

If you think this issue is not really a duplicate of #8757, please say so.

[Eric678]

Intentional! Simply if the other issue is fixed then this must be different, so undo the dup!

[UndeadDevel]

I suppose we could make this issue about the new error message with operands int and str, while we leave the other one as fixed and being about the error message with operand float...in that case it would make sense to update the OP of this issue to reflect the different error message. Up to @andrewdavidwong to decide.

[unman]

Agreed - it's not a duplicate. The new error message should be noted in OP, and this should be re-opened.

[Kungers]

Encountered the same issue as the steps above (Tick Allow all for 5 Minutes).
Qubes Release: 4.2.1 (R4.2)