Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show internal qubes and their dependents (e.g., in App Menu) #8064

Closed
GWeck opened this issue Feb 25, 2023 · 12 comments
Closed

Option to show internal qubes and their dependents (e.g., in App Menu) #8064

GWeck opened this issue Feb 25, 2023 · 12 comments
Assignees
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience
Milestone

Comments

@GWeck
Copy link

GWeck commented Feb 25, 2023

Qubes OS release

R4.2 current weekly build

Brief summary

In Qubes R4.2, the new app menu does not show newly created dispVMs if their template is the default-mgmt-dvm.

Steps to reproduce

Create a new dispVM by right-clicking on some AppVM in the Qube Manager, and select the command Open console in qube. Then open the app menu and look for the dispVM just created and displayed in the Qube Manager.

Expected behavior

The new dispVM should be shown, possibly as some subentry to its dvm template default-mgmt-dvm, like it is the case for dispVMs created from some other dvm template, like fedora-37-dvm.

Actual behavior

The new dispVM is not shown in the app menu.

@GWeck GWeck added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug labels Feb 25, 2023
@GWeck GWeck changed the title New App manu does not show dispVMs just created New App menu does not show dispVMs created from default-mgmt-dvm Feb 25, 2023
@andrewdavidwong andrewdavidwong added C: manager/widget needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: app menu The primary user-facing GUI application menu in Qubes OS and removed C: manager/widget labels Feb 25, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Feb 25, 2023
@andrewdavidwong
Copy link
Member

If this is intentional, then it's arguably a UX bug, since the behavior of the system is defying users' expectations without taking appropriate steps to manage their expectations or explain the ostensibly inconsistent behavior.

@marmarta
Copy link
Member

default-mgmt-dvm is an internal qube. No internal qubes show in the menu (this or the previous one). I think the problem here is, if anything, showing this qube by default in Qube Manager - internal qubes are not to be touched in general, they do their thing in the background.

@GWeck
Copy link
Author

GWeck commented Feb 27, 2023

I see - that explains the behavior, but I find it somewhat confusing.

Could a configurable option be provided to show internal qubes and their possible dependants?

@marmarta
Copy link
Member

I guess, sure? But this will require some place to put those options, so a bit of UX-design-problem here. Maybe in the global qubes config...

@GWeck
Copy link
Author

GWeck commented Feb 27, 2023

That's a good, plausible location.

@andrewdavidwong
Copy link
Member

andrewdavidwong commented Feb 27, 2023

default-mgmt-dvm is an internal qube. No internal qubes show in the menu (this or the previous one). I think the problem here is, if anything, showing this qube by default in Qube Manager - internal qubes are not to be touched in general, they do their thing in the background.

Yes, so I think this shows that more UX work may still remain for #6604, because users are still confused about the nature of "internal" qubes. So, they either need to be better hidden (which sounds like the path you're leaning toward) or better explained (in the broad sense of any UX solution that allows users to understand them).

The part about hiding internal qubes in the Qube Manager, specifically, sounds like #8042.

I guess, sure? But this will require some place to put those options, so a bit of UX-design-problem here. Maybe in the global qubes config...

I'll update this issue to describe the enhancement request you're describing, but it might also be worth considering whether this should just be closed as a duplicate of #6604 (and #6604 reopened to pursue a more general UX strategy for dealing with internal qubes, especially if you favor the hiding strategy, which seems like the opposite of this issue post-update).

@andrewdavidwong andrewdavidwong added T: enhancement C: manager/widget ux User experience and removed T: bug needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: app menu The primary user-facing GUI application menu in Qubes OS labels Feb 27, 2023
@andrewdavidwong andrewdavidwong modified the milestones: Release 4.2, Release TBD Feb 27, 2023
@andrewdavidwong andrewdavidwong changed the title New App menu does not show dispVMs created from default-mgmt-dvm Option to show internal qubes and their dependents (e.g., in App Menu) Feb 27, 2023
@GWeck
Copy link
Author

GWeck commented Feb 28, 2023

Hiding internal qubes could be problematic at least for default-mgmt-dvm because this qube can be the parent of update qubes and the terminal qubes as described above. Are these to be considered internal, too?

  • If not, they seem to hang in the air if their parent is hidden.
  • If yes, why are there actions performed by something invisible?

So, for me, hiding internal qubes causes more problems than it solves.

@marmarek
Copy link
Member

User is not supposed to run any applications in internal qubes manually, so hiding them from the menu makes sense. This applies to both default-mgmt-dvm and any DispVM based on it (for example an update mgmt qube is meant only to run that update, not anything else). They are shown in domains widget (side note: options to run terminal or file manager should be hidden for those, but they currently aren't), so you can see what takes your CPU/memory, and if something goes horribly wrong, you can kill them. But you really shouldn't do anything else with them.

@andrewdavidwong
Copy link
Member

andrewdavidwong commented Feb 28, 2023

User is not supposed to run any applications in internal qubes manually [...] But you really shouldn't do anything else with them.

Yes, but how is the user supposed to know this? The problem is that not enough is done UX-wise to communicate this information to the user. The user is right to question why only these qubes are missing from the App Menu and suspect it's a bug. It seems inconsistent, because there is no indication that these qubes are any different from all the other ones. Maybe we need some kind of special "internal" icon that always appears next to these qubes and has an explanatory tooltip stating that it's an internal qube and explaining what that means and/or a warning that pops up every time the user tries to interact with one of them.

@GWeck
Copy link
Author

GWeck commented Feb 28, 2023

This looks like two different, conflicting requirements:

  • Show internal qubes so that the user won't wonder why there is something doing something hidden and eating resources.
  • Hide internal qubes so that the user cannot do something malicious to them.

Both are valid, but contradicting positions. A compromise might be to show them, as you pointed out, in some special way, perhaps greyed out as some sort of inaccessible,l and blocking any attempt to do something with them (except killing them ???).

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue Mar 21, 2023
Now internal qubes get a title and a tooltip explanation,
plus the menu has only the shutdown and log options.

references QubesOS/qubes-issues#8064
@marmarta
Copy link
Member

Ok, I've now introduced two changes to make this better communicated:

  • internal qubes will be filtered out by default in qube manager, but can be shown in the 'View' menu
  • they will show up in the qui-domains widget, but the menu will be truncated (just log + shutdown/kill) and have an explicit "Internal qube" label with a tooltip explanation to the tune of "Please don't mess with it if you aren't 100% sure you know what you're doing".

marmarta added a commit to marmarta/qubes-desktop-linux-manager that referenced this issue Mar 22, 2023
Now internal qubes get a title and a tooltip explanation,
plus the menu has only the shutdown and log options.

references QubesOS/qubes-issues#8064
@marmarta
Copy link
Member

Ok, I think this can be closed: the internal qubes remain as they are (discouraging users to touch them), but there is a way to kill one in case of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. ux User experience
Projects
None yet
Development

No branches or pull requests

4 participants