Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whonix system tray icon breaks when right-clicking it #5704

Closed
eloquence opened this issue Mar 4, 2020 · 7 comments · Fixed by QubesOS/qubes-gui-daemon#36
Closed

Whonix system tray icon breaks when right-clicking it #5704

eloquence opened this issue Mar 4, 2020 · 7 comments · Fixed by QubesOS/qubes-gui-daemon#36
Labels
C: gui-virtualization P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-dom0-stable r4.1-bullseye-cur-test r4.1-buster-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-fc31-cur-test r4.1-stretch-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@eloquence
Copy link

Qubes OS version
The version of Qubes OS you're using (e.g., R4.0), available via the command cat /etc/qubes-release in a dom0 terminal.

R4.0

Affected component(s) or functionality
The component or functionality of Qubes OS that is not working as expected.

Whonix

Brief summary
A clear and concise summary of the bug.

The Whonix sys tray icon (sdwdate-gui) is very glitchy; clicking it causes the icon to "fall apart" in interesting ways. Other system tray icons are also somewhat glitchy (e.g., I've seen the network manager icon overlap with itself after extended use), but not as bad as the Whonix icon.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure you have a Whonix gateway and workstation VM running.
  2. Right-click the sdwdate-gui icon in the system tray repeatedly to get its context menu

Expected behavior
A clear and concise description of what you expected to happen.

The context menu works normally and the icon does not change.

Actual behavior
What actually happened (instead of what you expected to happen).

The icon falls apart while you click on it. It gets glitchier the more you interact with it.

Screenshots
If applicable, add screenshots to help explain your problem.

screenshot

From another report:

screenshot

@eloquence eloquence added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Mar 4, 2020
@marmarek
Copy link
Member

marmarek commented Mar 4, 2020

I can reproduce the issue by clicking on the icon. Interestingly sdwdate-gui is the only icon I have with this problem, others I've tried (hexchat, nm-applet, nexcloud) works fine.
I'll look more into this, but probably only next week.

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-daemon-4.1.4-1.fc31 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-daemon_4.1.4-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@ninavizz
Copy link
Member

Ok, this happened to me again, last night :/ Exactly as shown in the screen above. /cc @marmarta

@marmarek
Copy link
Member

The update is still in testing repository only and for R4.1 only. Will migrate to R4.0 in few weeks.

marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue May 17, 2020
When only part of the icon was redrawn, the code used wrong coordinates
and instead of putting that part back at the correct (x, y) coordinates,
it put it at (x, x). Additionally, it used cropped part of that
icon, because of again using (x, x) start coordinates (in an image already
containing just updated fragment) instead of (0, 0).

It worked accidentally only when the application always redraw the whole
icon (or at least its top-left part - so x=y=0). Which apparently is a
very common thing applications do.

Fixes QubesOS/qubes-issues#5704

(cherry picked from commit b5369a1)
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-dom0-4.0.11-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-gui-dom0-4.0.11-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gui-virtualization P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-dom0-stable r4.1-bullseye-cur-test r4.1-buster-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-fc31-cur-test r4.1-stretch-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants