Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting qube from vm settings can fail silently #5515

Closed
marmarta opened this issue Dec 14, 2019 · 4 comments · Fixed by QubesOS/qubes-manager#224
Closed

Deleting qube from vm settings can fail silently #5515

marmarta opened this issue Dec 14, 2019 · 4 comments · Fixed by QubesOS/qubes-manager#224
Assignees
@marmarta
Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-dom0-stable r4.1-centos7-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-fc31-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.0 updates

Comments

@marmarta
Copy link
Member

R4.0

QThread can fail to exit before the whole program exits, which leads to a silent failure and a whole lot of unpleasantness in .xsession errors.

Solution: wait for thread completion.
@marmarta marmarta added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Dec 14, 2019
@marmarta marmarta self-assigned this Dec 14, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Dec 15, 2019
@marmarta marmarta mentioned this issue Jan 8, 2020
Merged
@qubesos-bot
Copy link

Automated announcement from builder-github

The package manager has been pushed to the r4.1 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Jan 28, 2020
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-manager-4.1.5-1.fc31 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

marmarek pushed a commit to QubesOS/qubes-manager that referenced this issue Jan 29, 2020
@marmarta @marmarek
Handle deleting in VM Settings without silent fails
137ae8b 
Deleting qube will now show a Delete in Progress dialog box and
not exit QApplication before QThread finishes.

fixes QubesOS/qubes-issues#5515

(cherry picked from commit e17332d)
marmarta added a commit to marmarta/qubes-manager that referenced this issue Jan 30, 2020
@marmarta
Handle deleting in VM Settings without silent fails
35523aa 
Deleting qube will now show a Delete in Progress dialog box and
not exit QApplication before QThread finishes.

fixes QubesOS/qubes-issues#5515

(cherry picked from commit e17332d)
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-manager-4.0.41-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Jan 31, 2020
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-manager-4.0.41-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarta marmarta

Labels
C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-dom0-stable r4.1-centos7-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-fc31-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.0 updates
Development

Successfully merging a pull request may close this issue.

Handle deleting in VM Settings without silent fails marmarta/qubes-manager
3 participants
@marmarta @andrewdavidwong @qubesos-bot