Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qui-devices widget don't notice some attach/detach #5505

Closed
marmarek opened this issue Dec 7, 2019 · 15 comments · Fixed by QubesOS/qubes-app-linux-usb-proxy#15
Closed

qui-devices widget don't notice some attach/detach #5505

marmarek opened this issue Dec 7, 2019 · 15 comments · Fixed by QubesOS/qubes-app-linux-usb-proxy#15
Assignees
@marmarek
Labels
C: usb proxy P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-bullseye-stable r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc29-stable r4.0-fc30-stable r4.0-fc31-stable r4.0-stretch-stable r4.1-bullseye-cur-test r4.1-buster-stable r4.1-centos7-stable r4.1-dom0-cur-test r4.1-fc29-stable r4.1-fc30-stable r4.1-fc31-cur-test r4.1-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.0 updates

Comments

@marmarek
Copy link
Member

marmarek commented Dec 7, 2019

Qubes OS version
R4.0, R4.1

Affected component(s) or functionality
usb proxy

Brief summary
When device is detached spontaneously (for example because device is reset by the driver), or when attached by directly calling relevant qrexec service, qui-devices widget won't notice it. Calling qvm-usb tool properly display the state.

Expected behavior
qui-devices widget properly reflect the system state, as qvm-usb does.

Actual behavior
qui-devices gets desynchronized.

Additional context
It's because events are sent only when the action is triggeder via dom0 qubesd code. When it's done some other means, events are missing, even though qubesd do receive notifications about the change.

Solutions you've tried
Alternative: refresh more info if any info about devices changes: QubesOS/qubes-desktop-linux-manager#87
This is kind of similar to what qvm-usb does - it retrieve all the info from scratch on eatch call.

Related, non-duplicate issues
#4626

Reported by @rmol
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. C: usb proxy labels Dec 7, 2019
@marmarek marmarek self-assigned this Dec 7, 2019
@marmarek marmarek added this to the Release 4.0 updates milestone Dec 7, 2019
@marmarek marmarek mentioned this issue Dec 7, 2019
Merged
marmarek added a commit to marmarek/qubes-app-linux-usb-proxy that referenced this issue Dec 7, 2019
@marmarek
Ensure dom0 receives events on attach/detach
6a3e33f 
Dom0 monitors only /qubes-usb-devices qubesdb path itself, not the whole
tree - VM side is supposed to do an empty write there after doing series
of writes. Udev scripts advertising devices do that, but it was missing
in usb-export script.
Add missing write.

QubesOS/qubes-issues#5505
@qubesos-bot
Copy link

Automated announcement from builder-github

The package app-linux-usb-proxy has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Dec 10, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package app-linux-usb-proxy has been pushed to the r4.1 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Dec 10, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy-dom0-1.0.23-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy_1.0.23 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy_1.0.23 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy-dom0-1.0.23-1.fc29 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package app-linux-usb-proxy has been pushed to the r4.0 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy-dom0-1.0.27-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy_1.0.27+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-usb-proxy_1.0.27+deb9u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package app-linux-usb-proxy has been pushed to the r4.1 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarek marmarek

Labels
C: usb proxy P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-bullseye-stable r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc29-stable r4.0-fc30-stable r4.0-fc31-stable r4.0-stretch-stable r4.1-bullseye-cur-test r4.1-buster-stable r4.1-centos7-stable r4.1-dom0-cur-test r4.1-fc29-stable r4.1-fc30-stable r4.1-fc31-cur-test r4.1-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.0 updates
4 participants
@eloquence @marmarek @qubesos-bot @rmol