Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qvm-block allows attaching the same device to multiple qubes #4692

Closed
marmarek opened this issue Jan 6, 2019 · 6 comments
Closed

qvm-block allows attaching the same device to multiple qubes #4692

marmarek opened this issue Jan 6, 2019 · 6 comments
Assignees
@piotrbartman
Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

marmarek commented Jan 6, 2019

Qubes OS version:

R4.0

Steps to reproduce the behavior:

qvm-block at vm1 sys-usb:sda
qvm-block at vm2 sys-usb:sda

Expected behavior:

The second command fails as the device is already attached to vm1.

Actual behavior:

Both commands succeed, and device is available in both VMs, possibly leading to data corruption at least, security issues at worst.

Related issues:

Similar issue for R2.0: #950
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: major Priority: major. Between "default" and "critical" in severity. labels Jan 6, 2019
@marmarek marmarek added this to the Release 4.0 updates milestone Jan 6, 2019
@marmarek marmarek mentioned this issue Jan 6, 2019
Merged
@marmarek marmarek mentioned this issue Feb 15, 2021
Closed
@timdiels
Copy link

timdiels commented Jul 4, 2021

Seems this has become a duplicate of #6396 which also discusses whether to allow attaching the same device readonly.

@andrewdavidwong
Copy link
Member

Seems this has become a duplicate of #6396 which also discusses whether to allow attaching the same device readonly.

No, this was opened first, so #6396 would be a duplicate of this (if it is, in fact, a duplicate at all).

@andrewdavidwong andrewdavidwong mentioned this issue Jul 5, 2021
Closed
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Jul 5, 2021
@johnnyboy-3
Copy link

My setup is similiar, with persistence:

qvm-block --persistent vm1 sys-usb:sda
qvm-block --persistent vm2 sys-usb:sda

and it is intended, so this should be possible and not blocked.

  1. A sufficient fix for my setup would be to fail the boot of an AppVM, if the attached storage is already in use at another running AppVM (or Template, DVM, ...).
  2. A more advanced fix would be the simultaneously use of the attached storage in two (or more) AppVMs.

See also discussion @ #6396

@DemiMarie
Copy link

At a minimum, it should be possible to attach the same device read-only to as many qubes as one wishes. There is no risk of corruption there!

@andrewdavidwong
Copy link
Member

Is this still a problem in 4.1?

@johnnyboy-3
Copy link

yes

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
@marmarta marmarta moved this to Backend in Device UX Redesign Sep 19, 2023
@piotrbartman piotrbartman self-assigned this Feb 22, 2024
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue Mar 18, 2024
@piotrbartman
fix block device events
33e111b 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue Apr 10, 2024
@piotrbartman
q-dev: fix block device events
3578ea7 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue Apr 23, 2024
@piotrbartman
q-dev: fix block device events
a9c5418 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue Apr 28, 2024
@piotrbartman
q-dev: fix block device events
377ed21 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue May 8, 2024
@piotrbartman
q-dev: fix block device events
452c900 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue May 13, 2024
@piotrbartman
q-dev: fix block device events
2da252b 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
piotrbartman added a commit to piotrbartman/qubes-core-admin that referenced this issue Jun 2, 2024
@piotrbartman
q-dev: fix block device events
af8242e 
To properly report attachments or detachments of block devices, the logic has been moved to the extension. As a bonus, the following issue is fix: QubesOS/qubes-issues#4692
@github-project-automation github-project-automation bot moved this from Backend to Done in Device UX Redesign Jun 15, 2024
@qubesos-bot qubesos-bot mentioned this issue Jun 15, 2024
Closed
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jun 16, 2024
@apparatius apparatius mentioned this issue Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotrbartman piotrbartman

Labels
affects-4.1 This issue affects Qubes OS 4.1. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: major Priority: major. Between "default" and "critical" in severity. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Device UX Redesign
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@marmarek @timdiels @DemiMarie @andrewdavidwong @piotrbartman @johnnyboy-3