Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui-daemon: deprecated g_type_class_add_private() #4547

Closed
fepitre opened this issue Nov 25, 2018 · 1 comment
Closed

gui-daemon: deprecated g_type_class_add_private() #4547

fepitre opened this issue Nov 25, 2018 · 1 comment
Assignees
@marmarek
Labels
C: gui-virtualization
Milestone
Release 4.1

Comments

@fepitre
Copy link
Member

fepitre commented Nov 25, 2018

Refactor the code for handling the deprecated function g_type_class_add_private(). Currently, we silent the warning during the compilation for GCC8.
fepitre added a commit to fepitre/qubes-gui-daemon that referenced this issue Nov 25, 2018
@fepitre
Make gcc ignore deprecated function
f7426c8 
QubesOS/qubes-issues#4547
@fepitre fepitre added this to the Release 4.1 milestone Nov 25, 2018
@fepitre fepitre added task security This issue pertains to the security of Qubes OS. labels Nov 25, 2018
fepitre added a commit to fepitre/qubes-gui-daemon that referenced this issue Nov 25, 2018
@fepitre
Make gcc ignore deprecated function
077a3b6 
QubesOS/qubes-issues#4547
fepitre added a commit to fepitre/qubes-gui-daemon that referenced this issue Nov 25, 2018
@fepitre
Make gcc ignore deprecated function
7edd6c9 
QubesOS/qubes-issues#4547
@marmarek marmarek removed the security This issue pertains to the security of Qubes OS. label Mar 2, 2019
@marmarek
Copy link
Member

marmarek commented Mar 2, 2019

This whole task could be solved totally differently: replace mechanism for enabling/disabling audio input to a VM with something else. I.e. remove the whole pacat-control-object.c.

For GUI/Audio domain use (#1590), we need something else anyway, because dbus works only locally, but we need to enable/disable mic from dom0, even when pulseaudio run in dedicated VM.

I think it may be replaced with qubesdb. A per-vm entry in qubesdb instance local to Audio VM (which may or may not be dom0). Like /audio-input-enable/<VM NAME> with values 0 or 1. pacat-simple-vchan would only read value there (missing value treat as 0), while core-admin extension would write there.

@qubesos-bot qubesos-bot mentioned this issue Mar 2, 2019
Closed
@fepitre fepitre self-assigned this Mar 29, 2019
@marmarek marmarek assigned marmarek and unassigned fepitre Apr 3, 2019
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 4, 2019
@marmarek
pulse: replace dbus control with QubesDB + local socket
d0e75e3 
Since pacat-simple-vchan not necessary run in dom0 anymore, it needs
some better control mechanism than dbus, to be cross-domain compatible.
Use QubesDB for notification of the audio-input state. But use local
socket + qrexec service (coming in the next commit) for changing the
state, as it gives immediate feedback if it was received by
pacat-simple-vchan.

QubesOS/qubes-issues#4547
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 4, 2019
@marmarek
Update core-admin extension for new audio-input control mechanism
78676ae 
Call qrexec service for control, read state from QubesDB.

QubesOS/qubes-issues#1590
QubesOS/qubes-issues#4547
@marmarek marmarek mentioned this issue Apr 4, 2019
Merged
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 8, 2019
@marmarek
pulse: replace dbus control with QubesDB + local socket
400b91b 
Since pacat-simple-vchan not necessary run in dom0 anymore, it needs
some better control mechanism than dbus, to be cross-domain compatible.
Use QubesDB for notification of the audio-input state. But use local
socket + qrexec service (coming in the next commit) for changing the
state, as it gives immediate feedback if it was received by
pacat-simple-vchan.

QubesOS/qubes-issues#4547
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 8, 2019
@marmarek
Update core-admin extension for new audio-input control mechanism
8f007fa 
Call qrexec service for control, read state from QubesDB.

QubesOS/qubes-issues#1590
QubesOS/qubes-issues#4547
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 9, 2020
@marmarek
pulse: replace dbus control with QubesDB + local socket
de42489 
Since pacat-simple-vchan not necessary run in dom0 anymore, it needs
some better control mechanism than dbus, to be cross-domain compatible.
Use QubesDB for notification of the audio-input state. But use local
socket + qrexec service (coming in the next commit) for changing the
state, as it gives immediate feedback if it was received by
pacat-simple-vchan.

QubesOS/qubes-issues#4547
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 9, 2020
@marmarek
Update core-admin extension for new audio-input control mechanism
cc9e95a 
Call qrexec service for control, read state from QubesDB.

QubesOS/qubes-issues#1590
QubesOS/qubes-issues#4547
marmarek added a commit to marmarek/qubes-gui-daemon that referenced this issue Apr 9, 2020
@marmarek
Update core-admin extension for new audio-input control mechanism
f44e916 
Call qrexec service for control, read state from QubesDB.

QubesOS/qubes-issues#1590
QubesOS/qubes-issues#4547
@qubesos-bot qubesos-bot mentioned this issue Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarek marmarek

Labels
C: gui-virtualization
Projects
None yet
Milestone
Release 4.1
Development

No branches or pull requests
3 participants
@marmarek @andrewdavidwong @fepitre