Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer does not recover from suspend #3738

Closed
unman opened this issue Mar 24, 2018 · 25 comments
Closed

Computer does not recover from suspend #3738

unman opened this issue Mar 24, 2018 · 25 comments
Labels
C: Xen P: major Priority: major. Between "default" and "critical" in severity. r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc26-stable r4.0-jessie-stable r4.0-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@unman
Copy link
Member

unman commented Mar 24, 2018

Qubes OS version:

R4.0 rc5

Affected component(s):

Resume after suspend


Steps to reproduce the behavior:

Suspend by shutting lid

Expected behavior:

Resume after suspend should work

Actual behavior:

Computer does not recover.
Screen stays black and no response to keyboard ot trackpad use.
Fans do not spin up.
Sometimes computer will not restart.

General notes:

I do not think this is the same issue as #3705 since symptoms are slightly different.
This is an old x230, with RAM at only 8GB.
It worked flawlessly under rc5 until I applied updates from current-testing.
On previous packages from current, suspend/restore worked every time.
Since the update it fails every time.
I see nothing relevant in the logs.

Obviously i suspect the update to xen-4.8.3-4.
I'll revert the update and downgrade back to 8.3-3 to see what effect that has.


Related issues:

#3705 - but I think this is not the same.

@unman
Copy link
Member Author

unman commented Mar 24, 2018

I downgraded all relevant xen packages to 4.8.3-3 and previous functionality has been restored.
All seems to work fine now - at least, a couple of suspend/resume cycles have worked as expected, whereas with 3-4 they never worked.

@marmarek
Copy link
Member

@HW42 xen-4.8.3-4 breaks suspend.

@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: Xen labels Mar 24, 2018
@andrewdavidwong andrewdavidwong added this to the Release 4.0 milestone Mar 24, 2018
@tasket
Copy link

tasket commented Mar 28, 2018

Is 4.8.3-4 the Spectre mitigation update?

@unman Lenovo recently released BIOS updates with Spectre mitigation support for Ivy Bridge Thinkpads like the x230. Have you updated?

@donob4n
Copy link

donob4n commented Mar 28, 2018

Hi,

I also had suspend/resume broken and booting an older kernel (4.14.13-2) works fine.

@andrewdavidwong
Copy link
Member

Is 4.8.3-4 the Spectre mitigation update?

According to QSB 37, it's 4.8.3-3.

@o-
Copy link

o- commented Apr 1, 2018

Hi, I can confirm I had the same issue with X1 5th gen carbon. I believe it was after microcode_ctl update, rather than xen update, but am not sure. Wakeup only worked when I shut down every VM, (even sys-usb and sys-net). Latest bios upgrade by lenovo fixed the issue. Seems to reliably work again.

@Simon-Davies
Copy link

I was also experiencing this issue on my Dell XPS 15 but flashing the latest Bios update fixed it for me.

@x4lldux
Copy link

x4lldux commented Apr 3, 2018

I'm having the same problem with Asus Z10PE-D16 WS motherboard.
I've tested this in those configurations and it seems to be xen-4.8.3-4 related:
xen-4.8.3-4 & microcode update: resuming doesn't work 👎
xen-4.8.3-4 & no microcode update: resuming doesn't work 👎
xen-4.8.3-3 & microcode update: resuming works 👍
xen-4.8.3-3 & no microcode update: resuming works 👍

@Simon-Davies
Copy link

Simon-Davies commented Apr 3, 2018

@x4lldux Have you tried updating your system's Bios firmware by flashing the latest version from the manufacturer? This fixed the issue for me.

@x4lldux
Copy link

x4lldux commented Apr 3, 2018

@Simon-Davies should have mentioned ealier, already have the latest version and that doesn't change the above results.

@andrewdavidwong andrewdavidwong added the P: major Priority: major. Between "default" and "critical" in severity. label Apr 4, 2018
HW42 added a commit to HW42/qubes-vmm-xen that referenced this issue Apr 11, 2018
@HW42
Copy link

HW42 commented Apr 11, 2018

QubesOS/qubes-vmm-xen#35 should fix this in practice. But is strictly not complete:

Jan Beulich:

Of course none of this addresses a possible NMI or #MC occurring before the microcode loading.

Edit: Fixed link to PR.

@marmarek
Copy link
Member

In what cases those could happen?

@HW42
Copy link

HW42 commented Apr 11, 2018

TBH I don't know. AFAIU one case would be hardware faults (RAM or bus errors). Not sure if Xen is using any breakpoint tricks ore something similar for profiling and if this can be active during early resume.

FWIW: I never observed any such problems during testing.

Based on https://lists.xenproject.org/archives/html/xen-devel/2018-04/msg00836.html I assume that Jan or Andrew will come up with a follow-up patch to disable IBRS/IBPB during suspend.

@qubesos-bot
Copy link

Automated announcement from builder-github

The package xen_4.8.3-5+deb9u1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package python2-xen-4.8.3-5.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component vmm-xen (including package python2-xen-4.8.3-5.fc26) has been pushed to the r4.0 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@donob4n
Copy link

donob4n commented Apr 17, 2018

@marmarek I'm pretty confused

The package python2-xen-4.8.3-5.fc25 has been pushed to the r4.0 testing repository for dom0.

I checked it but I don't have this package installed in dom0. Is this normal? Has it relation with this bug?

I'm running an old kernel due this bug and I would like to run the latest version.

@marmarek
Copy link
Member

I checked it but I don't have this package installed in dom0. Is this normal?

Yes. Notification script is confused about multiple packages from a single source and just pick the first one. What is important is a package version (xen*-4.8.3-5.fc26)

@mirrorway
Copy link

The updates fixed my resume issues. :)

@donob4n
Copy link

donob4n commented Apr 19, 2018

This fixed also for me great :)

@qubesos-bot
Copy link

Automated announcement from builder-github

The package vmm-xen has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package vmm-xen has been pushed to the r4.0 stable repository for the Fedora centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component vmm-xen (including package python2-xen-4.8.3-7.fc26) has been pushed to the r4.0 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package xen_2001:4.8.3-7+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package python2-xen-4.8.3-8.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Xen P: major Priority: major. Between "default" and "critical" in severity. r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc26-stable r4.0-jessie-stable r4.0-stretch-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests