Allow overriding configuration file #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove per-VM configuration, but allow providing a path to the configuration file. This is in order to move GUI daemon configuration to qvm-features.
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 25, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a file to pass to qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 25, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a configuration file for qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 25, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a configuration file for qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 25, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a configuration file for qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 27, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a configuration file for qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
|
Is that still WIP? |
Mention that it's overrided by qvm-features now.
pwmarcz
added a commit
to pwmarcz/qubes-core-admin-client
that referenced
this pull request
Jun 29, 2020
Allow configuring options per VM or globally per GuiVM. The qvm-start-daemon program reads the options from VM features, and generates a configuration file for qubes-guid. Requires QubesOS/qubes-gui-daemon#47 (customizing the configuration file).
pwmarcz
changed the title
|
This is now ready, but the branch contains an additional commit that Github hasn't picked up here: pwmarcz@3c3454d |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/10655#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/9500#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/9500#dependencies
|
marmarek
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove per-VM configuration, but allow providing a path to the
configuration file. This is in order to move GUI daemon
configuration to qvm-features.
(WIP until the other part of the change is done)