-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new device API #139
new device API #139
Conversation
4d8854d
to
d762274
Compare
d762274
to
d3b2aeb
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024061301-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024052808-4.3&flavor=update
Failed tests23 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/101100#dependencies 38 fixed
Unstable tests
|
|
||
class MicDeviceExtension(qubes.ext.Extension): | ||
'''Extension to control microphone access | ||
class MicDevice(qubes.device_protocol.DeviceInfo): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing qubes.device_protocol
import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should be qubes.devices.DeviceInfo
... device_protocol
is in qubesadmin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right, I didn't update core-admin, but it should be OK now: QubesOS/qubes-core-admin/pull/579/commits/1004c670b76019ff83d0d1587d2a23c514c2cd4b
super().__init__( | ||
backend_domain=backend_domain, ident="mic", devclass="mic") | ||
self._interfaces = [ | ||
qubes.device_protocol.DeviceInterface("******", devclass="mic")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mic device needs some more info, to avoid confusing "unknown mic device" description:
https://openqa.qubes-os.org/tests/96797#step/qui_widgets_devices/4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to "microphone (build-in)"
936f77c
to
e99bf8f
Compare
e99bf8f
to
2062be5
Compare
after QubesOS/qubes-core-admin/pull/579
and after QubesOS/qubes-core-admin-client#274
QubesOS/qubes-issues#4626