Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always keep latin keyboard layout #139

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

jevank
Copy link
Contributor

@jevank jevank commented Jul 6, 2021

Setting only non-latin layout breaks hotkeys in various applications, so setup secondary 'us' to propagated from dom0.

Fixes QubesOS/qubes-issues#5431
Fixes QubesOS/qubes-issues#6690

Setting only non-latin layout breaks hotkeys in various applications, so setup secondary 'us' to propagated from dom0.

Fixes QubesOS/qubes-issues#5431
Fixes QubesOS/qubes-issues#6690
@marmarek
Copy link
Member

marmarek commented Jul 7, 2021

PipelineRefresh

@qubesos-bot
Copy link

qubesos-bot commented Jul 8, 2021

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/19587#dependencies

Failed tests

New failures

Compared to: https://openqa.qubes-os.org/tests/17576#dependencies

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/17576#dependencies

@solardiz
Copy link
Contributor

solardiz commented Jul 9, 2023

This addition of ,us layout breaks the si layout for me. This appears to help, and doesn't appear to break the shortcut keys:

+++ /usr/lib/qubes/qubes-keymap.sh	2023-07-09 15:00:38.085000000 +0200
@@ -11,7 +11,7 @@
     KEYMAP_LAYOUT="$(echo "$KEYMAP"+ | cut -f 1 -d +)"
     KEYMAP_VARIANT="$(echo "$KEYMAP"+ | cut -f 2 -d +)"
     KEYMAP_OPTIONS="$(echo "$KEYMAP"+ | cut -f 3 -d +)"
-    if [ "$KEYMAP_LAYOUT" != "us" ]; then
+    if [ "$KEYMAP_LAYOUT" != "us" -a "$KEYMAP_LAYOUT" != "si" ]; then
         KEYMAP_LAYOUT="$KEYMAP_LAYOUT,us"
         KEYMAP_VARIANT="$KEYMAP_VARIANT,"
     fi

I guess the problem isn't limited to just this one layout, so ideally we'd figure it out and fix it in a general manner, but meanwhile maybe we should get the above hack in?

@marmarek
Copy link
Member

marmarek commented Jul 9, 2023

This addition of ,us layout breaks the si layout for me

What exactly is broken then?

@solardiz
Copy link
Contributor

solardiz commented Jul 9, 2023

This addition of ,us layout breaks the si layout for me

What exactly is broken then?

With si,us, I am getting behavior same or similar to that for us alone - I cannot type characters specific to the si layout. With si alone, I can.

Somehow the same problem does not occur for ru,us, which appears to work just like ru alone.

I tested all of these with a Debian 10 VM.

solardiz added a commit to solardiz/qubes-gui-agent-linux that referenced this pull request Jul 12, 2023
solardiz added a commit to solardiz/qubes-gui-agent-linux that referenced this pull request Jul 12, 2023
marmarek pushed a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants