Modified keyboard layout handling #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
requested changes
Jun 22, 2020
| @@ -30,10 +27,7 @@ set_keyboard_layout() { | |||
| done | |||
| } | |||
|
|
|||
| if [ -n "$QUBES_KEYMAP" ]; then | |||
| set_keyboard_layout "$QUBES_KEYMAP" | |||
| fi | |||
There was a problem hiding this comment.
You need to leave at least this one (and corresponding qubesdb-read), to load initial keyboard layout.
|
|
||
| echo 'This program is deprecated; set qube property keyboard_layout instead.' |
There was a problem hiding this comment.
Print this on stderr. And exit with non-zero status (1?).
marmarta
force-pushed
the
keyboardlayout2020
branch
2 times, most recently
from
1be2667 to
9037533
Compare
marmarek
approved these changes
Jun 22, 2020
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/10655#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/9500#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/9500#dependencies
|
marmarta
force-pushed
the
keyboardlayout2020
branch
from
9037533 to
542d550
Compare
marmarek
reviewed
Jul 14, 2020
Removed qubes-changed-keyboard-layout script; it is replaced by simply setting VM property keyboard-layout. references QubesOS/qubes-issues#1396 references QubesOS/qubes-issues#4294
marmarta
force-pushed
the
keyboardlayout2020
branch
from
542d550 to
59ae770
Compare
marmarek
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed qubes-changed-keyboard-layout script; it is replaced by simply setting
VM property keyboard-layout.
requires QubesOS/qubes-core-admin#350
references QubesOS/qubes-issues#1396
references QubesOS/qubes-issues#4294