Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework qubes-i3status in python and improve snd and net status #17

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Jun 30, 2024

@fepitre
Copy link
Member Author

fepitre commented Jun 30, 2024

It needs testing and validation. I wrote it pretty straightforward without testing it on several machines.

@mpas97
Copy link

mpas97 commented Jul 1, 2024

Thank you a lot for this rework. What I can observe (change in behaviour compared to current one):

  • The qube count now shows one more. I get the same number including dom0.

  • The whole status bar only refreshes around every 30s. Which is quite laggy, espacially for time showing the seconds. Before it was at least once per second, as time counts up as it should. (Running the new script in dom0 echoes every second though) I also observe this delay when restarting i3. The old version has direct output, the new only after some time

@fepitre
Copy link
Member Author

fepitre commented Jul 1, 2024

Thank you a lot for this rework. What I can observe (change in behaviour compared to current one):

* The qube count now shows one more. I get the same number including dom0.

Yes, easy to fix.

* The whole status bar only refreshes around every 30s. Which is quite laggy, espacially for time showing the seconds. Before it was at least once per second, as time counts up as it should. (Running the new script in dom0 echoes every second though) I also observe this delay when restarting i3. The old version has direct output, the new only after some time

I need to investigate why it lags, it should not.

Thank you for your report.

@fepitre
Copy link
Member Author

fepitre commented Jul 1, 2024

Ok, it should be fixed, I've also lower the refresh time to 2 seconds, notably for volume and load. I've also changed the display of running qubes. It handles none, only one and multiple.

@mpas97
Copy link

mpas97 commented Jul 1, 2024

I really appreciate your work, looks all good or even better now.

@andrewdavidwong
Copy link
Member

Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put Closes QubesOS/qubes-issues#XXXX in the PR and/or commit message (where XXXX is the issue number). Closes is one of several special keywords that GitHub will recognize. If and when the PR is merged, GitHub will automatically close the associated issue.

@fepitre
Copy link
Member Author

fepitre commented Jul 1, 2024

Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put Closes QubesOS/qubes-issues#XXXX in the PR and/or commit message (where XXXX is the issue number). Closes is one of several special keywords that GitHub will recognize. If and when the PR is merged, GitHub will automatically close the associated issue.

Thank you, I'm aware of that. Indeed, it closes it.

@andrewdavidwong
Copy link
Member

The reason I mentioned it is because your PR is not auto-linked to QubesOS/qubes-issues#9094, so I guess it needs to be in the PR message instead of (or in addition to) the commit message.

@fepitre
Copy link
Member Author

fepitre commented Aug 9, 2024

@marmarek friendly ping for merging this one please.

@marmarek marmarek merged commit e9aa0f0 into QubesOS:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qubes-i3status - json invalid
4 participants