qrexec-client: handle failed service exec #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 74.51% 74.54% +0.03%
==========================================
Files 41 41
Lines 6612 6632 +20
Branches 474 477 +3
==========================================
+ Hits 4927 4944 +17
- Misses 1431 1432 +1
- Partials 254 256 +2
Continue to review full report at Codecov.
|
pwmarcz
changed the title
|
Do you think it fixes the issue in https://openqa.qubes-os.org/tests/7251 ? |
pwmarcz
changed the title
Otherwise, qrexec-client just hangs when it fails to spawn a process, or connect to a socket service. This corresponds to the fix for qrexec-agent in commit 95fa4bb.
pwmarcz
added a commit
to pwmarcz/qubes-gui-agent-linux
that referenced
this pull request
Mar 28, 2020
This makes icon-sender handle GUI restart, same as qubes-gui and audio. However, in this case we are not running raw vchan, but Qubes RPC, so the procedure is more complicated: we start a qrexec-client-vm subprocess, and restart it if it breaks. Needs icon-receiver to be a service with wait-for-session (QubesOS/qubes-gui-daemon#37), and fix for socket services in dom0 (QubesOS/qubes-core-qrexec#42).
pwmarcz
added a commit
to pwmarcz/qubes-gui-agent-linux
that referenced
this pull request
Mar 28, 2020
This makes icon-sender handle GUI restart, same as qubes-gui and audio. However, in this case we are not running raw vchan, but Qubes RPC, so the procedure is more complicated: we start a qrexec-client-vm subprocess, and restart it if it breaks. Needs icon-receiver to be a service with wait-for-session (QubesOS/qubes-gui-daemon#37), and fix for socket services in dom0 (QubesOS/qubes-core-qrexec#42).
|
AFAICT, the impact for this one is minimal - only socket services in dom0 that are not running at the moment. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/7365#dependencies Failed tests
New failuresCompared to: https://openqa.qubes-os.org/tests/6362#dependencies
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/6362#dependencies
|
pwmarcz
added a commit
to pwmarcz/qubes-gui-agent-linux
that referenced
this pull request
Mar 30, 2020
This makes icon-sender handle GUI restart, same as qubes-gui and audio. However, in this case we are not running raw vchan, but Qubes RPC, so the procedure is more complicated: we start a qrexec-client-vm subprocess, and restart it if it breaks. Needs icon-receiver to be a service with wait-for-session (QubesOS/qubes-gui-daemon#37), and fix for socket services in dom0 (QubesOS/qubes-core-qrexec#42).
marmarek
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, qrexec-client just hangs when it fails to spawn a
process, or connect to a socket service.
This corresponds to the fix for qrexec-agent in commit
95fa4bb.