Fix DNF5 repoquery #522
Fix DNF5 repoquery #522
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 70.57% 70.14% -0.43%
==========================================
Files 3 3
Lines 469 469
==========================================
- Hits 331 329 -2
- Misses 138 140 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Downloading templates fail. I guess "downloadurl" plugin is no longer compatible? |
I am not sure. I am experiencing other bugs. With my previous patch (using |
|
I got that mixed a little. We have two problems:
|
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
from
fdabf0e to
b06506a
Compare
|
The patch that I just uploaded should work for both DNF4 and DNF5. But it is ugly and i do not like it. |
|
OK. I admit that I have been a total idiot in this case. I just understood that And dnf5 download plugin is written in C language. Whereas the old dnf4 download plugin was written in Python. And I have currently zero clue if there would be any workaround to use the old Python one with DNF5. |
|
This line in dnf5 download plugin is what that has to be changed/improved to allow In the meantime, the ugly patch I suggested in this PR should allow temporal use of @marmarek What is your suggestion? |
|
Well, first mirror is better than qvm-template broken completely. But that isn't suitable long term solution, without listing more URLs, fallback to other mirrors won't work (and it is needed sometimes, especially when downloading over Tor). |
|
What about adding a DNF5 "downloadurl" plugin, based on the "download" command upstream? It was pretty simple to make "downloadurl" plugin for DNF4 ;) |
Exactly. Fortunately
I started working on this. It is a little bit different from DNF4 situation since we are dealing with compiled plugins. My plan is as follow:
This should take some time. My aim is to have some positive results within a week. |
|
In the meantime, I'll merge some of the other PRs and build initial template for testing. It will have broken VM-side of qvm-template still, but will ease testing other stuff (and also allows running this PR on openQA) |
|
Update: Path to Issue reference: rpm-software-management/dnf5#1734 |
|
Update: Individual In the next step, we have to decide how long to wait for the upstream maintainers to make a decision if they like the patch or reject it. If they reject it or do not make a decision within the reasonable time, packaging & building instructions for Qubes OS specific plugin is available here. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024101803-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 198 fixed
Unstable tests
|
The qvm-template related tests seems to be green :) (but that's ofc without the --all-mirrors support in DNF5 yet) |
That is good. In the meantime, DNF maintainers are in the process of approving the new option. And they asked it to be renamed to |
OK. Upstream DNF5 maintainers have accepted On the issue of |
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
from
b06506a to
2f3746a
Compare
I rushed in to replying to your previous message after reading the 1st line (sorry for that. some lack of sleep here). I just adjusted the PR. I have not tested it personally as I am not currently behind my Qubes OS machine. Hopefully the adjustment should work without any issues as it quite simple. I appreciate if you could do a sanity check. |
|
This will not work. DNF5 maintainers had asked me for space-separated URLs rather than each on a new line. readarray has to be adjusted as well. |
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
2 times, most recently
from
ba2d54e to
0fd6a1d
Compare
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
from
0fd6a1d to
bc8476f
Compare
|
@marmarek |
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
from
bc8476f to
af89baf
Compare
alimirjamali
force-pushed
the
DNF5-repoquery-fix
branch
from
af89baf to
e0cecd0
Compare
|
@marmarek The two requested changes are applied. |
related: QubesOS/qubes-core-admin-client#308