Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dnf5 for qubes-download-dom0-update.sh #521

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

alimirjamali
Copy link
Contributor

dnf5 does not print "--downloadonly" help with -h by default

For QubesOS/qubes-issues#9244

@alimirjamali alimirjamali marked this pull request as draft August 22, 2024 16:34
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (5b860df) to head (edae40c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   70.57%   70.14%   -0.43%     
==========================================
  Files           3        3              
  Lines         469      469              
==========================================
- Hits          331      329       -2     
- Misses        138      140       +2     
Flag Coverage Δ
70.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alimirjamali alimirjamali marked this pull request as ready for review August 22, 2024 18:39
@alimirjamali
Copy link
Contributor Author

Using --version to detect dnf5 in Debian scenario

@alimirjamali alimirjamali marked this pull request as draft August 22, 2024 19:34
@alimirjamali alimirjamali force-pushed the Issue-9244 branch 2 times, most recently from 453f766 to 9994007 Compare August 22, 2024 19:50
@alimirjamali
Copy link
Contributor Author

Reason for amendments:

In dnf5:

  1. check-update is renamed to check-upgrade
  2. The order of command & argument does matter very much.

@alimirjamali alimirjamali marked this pull request as ready for review August 22, 2024 20:02
@alimirjamali
Copy link
Contributor Author

PipelineRetry

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the few comments, it seems to work

package-managers/qubes-download-dom0-updates.sh Outdated Show resolved Hide resolved
package-managers/qubes-download-dom0-updates.sh Outdated Show resolved Hide resolved
@marmarek marmarek merged commit 68abc4c into QubesOS:main Sep 28, 2024
3 of 4 checks passed
@alimirjamali alimirjamali deleted the Issue-9244 branch October 29, 2024 19:22
marmarek pushed a commit that referenced this pull request Nov 5, 2024
According to PR comments:
#521 (comment)
#521 (comment)

(cherry picked from commit edae40c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants