Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch /etc/sudoers on Archlinux #519

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

alimirjamali
Copy link
Contributor

@alimirjamali
Copy link
Contributor Author

The other approach would be prepending /run/qubes/bin for secure_path in sudoers config file.

@alimirjamali
Copy link
Contributor Author

CI/CD bot fails on building Archlinux package. The log is very cluttered and hard to analysis

@marmarek
Copy link
Member

Maybe better place a file in /etc/sudoers.d instead of patching existing file?

@alimirjamali
Copy link
Contributor Author

Maybe better place a file in /etc/sudoers.d instead of patching existing file?

It is done.

@marmarek
Copy link
Member

23:11:03 [qb.build_archlinux.core-agent-linux.vm-archlinux.build] make: Leaving directory '/build/qubes-vm-core/src/qubes-vm-core-4.3.5-1.1/qubes-rpc/thunar'.
23:11:03 [qb.build_archlinux.core-agent-linux.vm-archlinux.build] install: cannot create regular file '/build/qubes-vm-core/pkg/qubes-vm-core/etc/sudoers.d/qubes_secure_path': No such file or directory.
23:11:04 [qb.build_archlinux.core-agent-linux.vm-archlinux.build] .[1m.[31m==> ERROR:.[0m.[1m A failure occurred in package_qubes-vm-core()..[0m.
23:11:04 [qb.build_archlinux.core-agent-linux.vm-archlinux.build] .[1m    Aborting....[0m.

@alimirjamali
Copy link
Contributor Author

I see. I already had the /etc/sudoers.d because of the passwordless root package. Patch is amended to create the directory.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (5b860df) to head (a9d5886).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files           3        3           
  Lines         469      469           
=======================================
  Hits          331      331           
  Misses        138      138           
Flag Coverage Δ
70.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarek marmarek merged commit a9d5886 into QubesOS:main Sep 26, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent update to upstream sudo broke Archlinux template updates
2 participants